github/weave-scope
1
0
Fork 0
mirror of https://github.com/weaveworks/scope.git synced 2026-03-03 18:20:27 +00:00
Code Issues Packages Projects Releases Wiki Activity
2,553 Commits 85 Branches 64 Tags
e6a474ead7f07bb268b2b90cd269fdf353b2b569
Commit Graph

2553 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Matthias Radestock
e6a474ead7 fix report store query chaining 
We fell victim to variable shadowing here. Each store would be fed the
original list of report keys, instead of only the ones that weren't
found in the previous store. So if a single report was missing from the
in-process cache, we would then fetch all reports from memcache. And if
that in turn was missing a single report we would fetch all reports from
S3.

We chain report stores for a reason - to reduce latency and, in case of
the in-process cache, eliminate decoding costs. So this bug has a huge
impact on query service performance.

To make matters worse, we return *all* the reports - now possibly in
triplicate. Fortunately, the SmartMerger filters these out, so at least
we were not incurring extra merge costs.
 2016-08-16 00:55:39 +01:00
Matthias Radestock
ed5463facd Merge pull request #1792 from weaveworks/more-accurate-memcache-hit-ratio 
allow more accurate reporting of memcache hit ratio
 2016-08-15 16:51:35 +01:00
Matthias Radestock
d6e5f0a154 allow more accurate reporting of memcache hit ratio 
A lot of time could pass between recording the request count and hit
count pertaining to a particular report fetching batch, which skewed
calculations cache hit ratios.

Fix that by defering the request count recording to the end, which is
when we record the hit count.
 2016-08-15 16:25:12 +01:00
Matthias Radestock
1a1021caae Merge pull request #1788 from weaveworks/fix-memcache-client-miss-and-leak-on-corrupt 
fix MemcacheClient.FetchReports miss & leak on corrupt report
 2016-08-15 11:33:25 +01:00
Jonathan Lange
14d0e4edfe Merge pull request #1787 from weaveworks/1767-docker-client-leak 
Bump github.com/fsouza/go-dockerclient
 2016-08-15 11:02:35 +01:00
Matthias Radestock
9cf178f130 fix MemcacheClient.FetchReports miss & leak on corrupt report 
Problem: Decoding a corrupt report grows the 'missing' list. Since we
are waiting for 'len(keys)-len(missing)' decoder go-routines, this
results in waiting for fewer go-routines than we should. The surplus
go-routines leak and we ignore their reports. And since the keys of the
ignored reports are not included in 'missing', we won't attempt to fetch
them from S3 either. Oops.

Fix: calculate the number of go-routines once, at the beginning.
 2016-08-15 10:44:29 +01:00
Alfonso Acosta
c39b16ae9f Bump github.com/fsouza/go-dockerclient 
To include https://github.com/fsouza/go-dockerclient/pull/562 , which
fixes https://github.com/weaveworks/scope/issues/1767
 2016-08-15 09:34:18 +00:00
Simon
6f9912501d Merge pull request #1784 from weaveworks/1745-right-align-column-numbers 
Right align numbers, left align strings.
 2016-08-15 09:43:31 +02:00
Simon Howe
3851d9c662 Right align numbers, left align strings. 
ala excel/spreadsheets etc.
 2016-08-12 15:18:39 +02:00
Matthias Radestock
6334836f69 Merge pull request #1768 from weaveworks/1202-silence-abnormal-close 
silence abnormal websocket close

Fixes #1202.
 2016-08-12 13:53:51 +01:00
Matthias Radestock
21c188d600 Merge pull request #1739 from weaveworks/1730-no-node-copy 
Remove and optimize more Copy()s
 2016-08-12 12:30:54 +01:00
Alfonso Acosta
cfb686b546 Merge pull request #1774 from weaveworks/1759-remove-k8s-id-col 
Remove kubernetes_id column from the grid view.
 2016-08-11 17:43:21 +01:00
Alfonso Acosta
22434616fa Merge pull request #1782 from weaveworks/1779-elide-service-token 
Elide service-token when logging commandline arguments
 2016-08-11 17:12:27 +01:00
Alfonso Acosta
04349cc86d Merge pull request #1783 from weaveworks/1777-do-not-bitch-on-stop 
Don't complain when stopping Scope if it wasn't running
 2016-08-11 16:57:05 +01:00
Alfonso Acosta
0c3235ae3d Review feedback 2016-08-11 15:41:07 +00:00
Alfonso Acosta
0a1232ec3c Don't complain when stopping Scope if it wasn't running 2016-08-11 15:21:06 +00:00
Alfonso Acosta
276ffa338e Elide service-token when logging commandline arguments 2016-08-11 15:07:08 +00:00
Alfonso Acosta
77bb186039 Review feedback 2016-08-10 16:19:58 +00:00
Alfonso Acosta
166bdf13f3 Remove redundant kubernetes ID 2016-08-10 16:01:28 +00:00
Simon
1d4904d56f Merge pull request #1775 from weaveworks/1749-filter-by-relatives 
Adds support for filtering graph/table by relatives
 2016-08-10 16:01:25 +02:00
Alfonso Acosta
9320b10a2e Merge pull request #1780 from weaveworks/1733-scope-loopback-connections 
Handle loopback addresses correctly when tracking connections
 2016-08-10 14:52:44 +01:00
Simon
718bf5b3a0 Merge pull request #1773 from weaveworks/1692-scale-node-labels-with-nodes 
Scale node labels with the node's size.
 2016-08-10 14:32:45 +02:00
Simon Howe
5cf8ee2a6b Move chrome-css-fix out of js into css w/ comment 2016-08-10 14:10:10 +02:00
Alfonso Acosta
94eb7454ff Do not attribute connections to containers based on loopback addresses 2016-08-10 10:56:37 +00:00
Alfonso Acosta
3892273096 Append namespace to endpoint scope for loopback connections 2016-08-10 10:43:04 +00:00
Mike Lang
d0f0e8d92e Merge pull request #1776 from weaveworks/mike/launcher/fix-whitespace 
launcher script: Fix inconsistent whitespace
 2016-08-09 12:18:49 -07:00
Simon Howe
4d5d0d5dc2 Fixes origin of node-details-panel expanding animation 2016-08-09 20:16:23 +02:00
Simon Howe
8f4b3ab97d Fixes animation of node labels on focus. 
Was a bit janky there for a bit.
 2016-08-09 20:00:39 +02:00
Mike Lang
7aec1e172d launcher script: Fix inconsistent whitespace 2016-08-09 09:57:12 -07:00
Simon Howe
fc2fcfb298 Adds support for filtering node/table by relatives 
Now that they are available in the summary data.
 2016-08-09 18:20:43 +02:00
Alfonso Acosta
b8c99ed7cc Revert "Cache generated ids to relieve pressure on the GC" 
It wasn't working as noticed by @rade (note the err != nil) and was complicating
the code.

This reverts commit 2f760f2f33.
 2016-08-09 14:59:28 +00:00
Simon Howe
564c64ec21 Fixes truncating of labels 2016-08-09 16:07:25 +02:00
Simon Howe
5846222fe1 Scale node labels with the node's size. 
- Within certain bounds. Still have min-label size, mainly effects nodes
  that get really big.
- Set a max size on nodes too, really big ones lose their border.
 2016-08-09 14:57:13 +02:00
Alfonso Acosta
d06547e596 Merge pull request #1770 from weaveworks/1750-extend-k8s-pause-containers 
Identify kubernetes pause containers more broadly
 2016-08-09 11:26:07 +01:00
Paul Bellamy
c40a1b0c3d Merge pull request #1751 from kinvolk/krnowak/lint 
Lint fixes
 2016-08-09 09:45:10 +01:00
David
a11ddfbaa6 Merge pull request #1766 from weaveworks/1715-search-label 
Fixes search icon position on chrome
 2016-08-08 18:39:27 +02:00
Alfonso Acosta
b64686ffc3 Identify kubernetes pause containers more broadly 2016-08-08 14:16:07 +00:00
Matthias Radestock
7480654aaf don't complain about closed websockets in pipe connections 2016-08-06 00:06:34 +01:00
Matthias Radestock
c3315f9c99 reduce log level for absent pipe 
since we can get this when a pipe has been closed normally
 2016-08-05 23:47:35 +01:00
Matthias Radestock
df467d80de log error as error 2016-08-05 23:37:33 +01:00
Matthias Radestock
6d9194cfaf treat EOF and ErrClosedPipe in websocket connections as uninteresting 
both occur in various states of disconnectedness
 2016-08-05 23:32:34 +01:00
Matthias Radestock
4d746a6cf4 log container id in attach/exec errors 2016-08-05 19:23:54 +01:00
Matthias Radestock
3af45583e5 don't log attach/exec close 
since we don't log the start either
 2016-08-05 19:19:09 +01:00
Matthias Radestock
190e840484 reduce some pipe log noise 
NB: the m/t version remains unchanged since it is generally a lot
noisier
 2016-08-05 19:16:15 +01:00
Matthias Radestock
25011f20e0 silence websocket.CloseAbnormalClose 
We get this when windows are closed, so really should treat it just
like any other close.
 2016-08-05 19:07:03 +01:00
David Kaltschmidt
4c5ac4fc33 Fixes search icon position on chrome 
* simplify search icon and label markup

Fixes #1715
 2016-08-05 19:29:59 +02:00
Alfonso Acosta
9740fcca40 Merge pull request #1765 from weaveworks/release-0.16 
Release 0.16.2
 2016-08-05 16:38:43 +01:00
Alfonso Acosta
b00c942089 Release 0.16.2 v0.16.2 2016-08-05 15:04:52 +00:00
Alfonso Acosta
a5a015ea6b Merge pull request #1764 from weaveworks/fix-1755 
Docker for Mac 1.12 has only one network mode (close #1755)
 2016-08-05 15:33:09 +01:00
Ilya Dmitrichenko
d7c40827c8 Docker for Mac 1.12 has only one network mode (close #1755) 2016-08-05 15:06:07 +01:00