github/weave-scope
1
0
Fork 0
mirror of https://github.com/weaveworks/scope.git synced 2026-03-03 02:00:43 +00:00
Code Issues Packages Projects Releases Wiki Activity

Do not attribute connections to containers based on loopback addresses

Browse Source
This commit is contained in:
Alfonso Acosta
2016-08-10 10:56:37 +00:00
parent 3892273096
commit 94eb7454ff
2 changed files with 8 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
render/container.go
View File

@@ -264,6 +264,11 @@ func MapContainer2IP(m report.Node) []string {
if !ok {
continue
}
// loopback addresses are shared among all namespaces
// so we can't use them to attribute connections to a container
if report.IsLoopback(addr) {
continue
}
id := report.MakeScopedEndpointNodeID(scope, addr, "")
result = append(result, id)
}

5
report/id.go
View File

@@ -44,7 +44,7 @@ func makeAddressID(hostID, namespaceID, address string) string {
addressIP := net.ParseIP(address)
if addressIP != nil && LocalNetworks.Contains(addressIP) {
scope = hostID
} else if isLoopback(address) {
} else if IsLoopback(address) {
scope = hostID
if namespaceID != "" {
scope += "-" + namespaceID
@@ -176,7 +176,8 @@ func ExtractHostID(m Node) string {
return hostID
}
func isLoopback(address string) bool {
// IsLoopback ascertains if an address comes from a loopback interface.
func IsLoopback(address string) bool {
ip := net.ParseIP(address)
return ip != nil && ip.IsLoopback()
}