Commit Graph

4046 Commits

Author SHA1 Message Date
Matthias Radestock
ad7b5cdc19 refactor: remove pointless interface
premature abstraction
2017-07-11 19:38:06 +01:00
Matthias Radestock
8a56540648 refactor: eliminate global var 2017-07-11 19:38:06 +01:00
Matthias Radestock
8bd0188537 respect UseConntrack setting in ebpf initialisation 2017-07-11 19:37:11 +01:00
Matthias Radestock
7ea0800f8b refactor: extract helper to get initial flows 2017-07-10 07:34:20 +01:00
Matthias Radestock
07e7adbd63 refactor: make performFlowWalk data flow more obvious 2017-07-10 07:22:12 +01:00
Matthias Radestock
1abc886fbd Merge pull request #2695 from weaveworks/2687-ebpf-init-race-segfault
fix ebpf init race segfault

Fixes #2687
2017-07-07 21:55:49 +01:00
Filip Barl
a390c7633e Make graph layout zoom limits constant (#2678)
* Make zoom limits such that nodes are always between 1px and 200px big.

* Increased minimal node size from 1px to 3px.
2017-07-07 19:52:42 +02:00
Filip Barl
8f22d58cab Last line of defense against overlapping nodes in graph layout (#2688)
* Refresh the layout once more at the end if previous heuristics cause an overlap.

* Added mixpanel tracking.
2017-07-07 19:22:04 +02:00
Roland Schilter
7f078a8a09 Merge pull request #2694 from weaveworks/yarn-pack-is-not-npm-pack
Fix `yarn pack` ignoring directory cli flag
2017-07-07 15:55:00 +02:00
Roland Schilter
202e1569e5 Fix yarn pack ignoring directory cli flag 2017-07-07 13:00:23 +02:00
Matthias Radestock
19e45ec248 refactor: eliminate global var 2017-07-07 10:18:43 +01:00
Matthias Radestock
8cf79b2e4a bump tcptracer-bpf version and use it to fix race
We defer starting the ebpf tracer until we've set the global var which
is referenced by the callback functions. Previously the var could be
unset when the callbacks are invoked, resulting in a segfault.

Fixes #2687.
2017-07-07 06:56:28 +01:00
Roland Schilter
683312ebc1 Merge pull request #2691 from weaveworks/fix-build-pkg-version
Yarn prefixes version with `v` when packing
2017-07-06 22:47:46 +02:00
Roland Schilter
c3ee9cda91 Yarn prefixes version with v when packing 2017-07-06 22:13:21 +02:00
Matthias Radestock
e48c067367 Merge pull request #2690 from weaveworks/2689-limit-ebpf-tests
don't use eBPF in a couple of tests
2017-07-06 19:27:32 +01:00
Matthias Radestock
672beb64fa don't use eBPF in a couple of tests
There really should be two variants - with and without eBPF - but the
latter is broken due to #2689.
2017-07-06 18:26:28 +01:00
Filip Barl
8f2d47ce4e Time travel redesign (#2651)
* Initial top level control.

* Added the jump buttons.

* Tiny styling adjustments.

* Massive renaming.

* Pause info

* Added slider marks.

* Improved messaging.

* Freeze all updates when paused.

* Repositioned for Configure button.

* Improved the flow.

* Working browsing through slider.

* Small styling.

* Hide time travel button behind the feature flag.

* Fixed actions.

* Elements positioning corner cases.

* Removed nodes delta buffering code.

* Fixed the flow.

* Fixed almost all API call cases.

* Final touches

* Fixed the tests.

* Fix resource view updates when time travelling.

* Added some comments.

* Addressed some of @foot's comments.
2017-07-06 16:06:55 +02:00
Roland Schilter
cf8a95c878 Merge pull request #2683 from weaveworks/table-overflow-plus-one
Show table overflow only if limit exceeded by 2+
2017-07-06 15:50:11 +02:00
Roland Schilter
dfda3e0b0b Show table overflow only if limit exceeded by 2+
Having to toggle a +1 feels weird while that +1 takes up
the same vertical space as displaying that row.
2017-07-06 13:56:03 +02:00
Roland Schilter
0dbea45e1e Merge pull request #2676 from weaveworks/2606-update-readme-to-use-yarn
Update README/Makefile/package.json to use yarn
2017-07-06 13:33:48 +02:00
Alfonso Acosta
13fa738290 Merge branch 'release-1.5' 2017-07-05 21:11:33 +00:00
Mike Lang
1a2ad9c013 Merge pull request #2685 from weaveworks/mike/render/fix-map2parent-pseudo-id
render/pod: Fix a typo in Map2Parent where UnmanagedID will always be used for noParentsPseudoID
2017-07-05 14:02:38 -07:00
Alfonso Acosta
af3b8cfabf Update doc versions v1.5.1 2017-07-05 20:43:15 +00:00
Matthias Radestock
d22d9d0768 Merge pull request #2682 from weaveworks/2681-image-counts
don't show container count in host detail panel image list

Fixes #2681.
2017-07-05 20:39:33 +01:00
Matthias Radestock
fd4f1f9d42 Merge pull request #2680 from weaveworks/2629-host-image-list
correct determination of a host's container images
2017-07-05 20:38:32 +01:00
Mike Lang
399cca026c render/pod: Fix a typo in Map2Parent where UnmanagedID will always be used for noParentsPseudoID
Thankfully we only ever set it to UnmanagedID right now, so no user-facing bug.
2017-07-05 11:33:06 -07:00
Alfonso Acosta
d38854fbda Release 1.5.1 2017-07-05 18:14:06 +00:00
Matthias Radestock
3d96174788 correct polarity of initial connections
Fixes #2644
2017-07-05 18:11:34 +00:00
Matthias Radestock
bfd53d28e5 ensure connections from /proc/net/tcp{,6} get the right pid
ProcNet.Next does not allocate Connection structs, for efficiency.
Instead it always returns a *Connection pointing to the same instance.
As a result, any mutations by the caller to struct elements that
aren't actually set by ProcNet.Next, in particular Connection.Proc,
are carried across to subsequent calls.

This had hilarious consequences: connections referencing an inode
which we hadn't come across during proc walking would be associated
with the process corresponding to the last successfully looked up
inode.

The fix is to clear out the garbage left over from previous calls.

Fixes #2638.
2017-07-05 18:11:24 +00:00
Matthias Radestock
c7a3f7c2fd Merge pull request #2675 from weaveworks/less-copy
refactor: remove unnecessary and dead Copy()
2017-07-05 14:33:31 +01:00
Matthias Radestock
0f4d17d868 don't show container count in host detail panel image list
The figure is inaccurate since it counts containers across all
hosts. Getting the count correct is non-trivial, so it's better to not
show the figure at all.

NB: the count still shows up on mouse-over of the link, but that is
defensible and not (very) confusing since the link represents the
image, not the image on a particular host, and it's the same count
that show up as the minor label in the container images view.

Fixes #2681.
2017-07-05 14:03:44 +01:00
Simon
77ba8aa8b3 Merge pull request #2666 from weaveworks/2660-fix-pid-truncation
Prevents 6 digit pids from being truncated in details panel/table mode
2017-07-05 14:27:56 +02:00
Simon
6310b48937 Switch to 56px small cols to fit in 6 digit pids 2017-07-05 14:27:34 +02:00
Simon
899c708593 Merge pull request #2648 from weaveworks/2627-node-grid-multiple-relatives
Show multiple relatives in the nodes-grid view
2017-07-05 14:25:55 +02:00
Matthias Radestock
a0fb2e1d73 cosmetic(ish) 2017-07-05 12:49:23 +01:00
Matthias Radestock
0c122acf06 correct determination of a host's container images
The same container image may be in use on multiple hosts. The
latest-map HostNodeID of a node in the ContainerImage topology is
therefore meaningless - it gets set to whatever host reported that
image last in the time window covered by the report. Hence using it as
a basis for mapping to hosts, as we did, a) fails to associate images
with all the right hosts (hence they are missing from the host details
panel), and b) causes that association to change semi-randomly (hence
the list in the details panel is unstable).

By contrast, the host topology parents of container image nodes is the
complete set of all hosts the image is used on. So making that the
basis for mapping fixes the problem.

The same technique - mapping based on host parents rather than
latest-map HostNodeID - also works for the other nodes we are mapping:
processes, containers and pods. So we might as well use it there
too. That's also what Map2Parent does in other topology renderers.

Fixes #2629.
2017-07-05 09:09:32 +01:00
Matthias Radestock
57bc34f411 Merge pull request #2673 from weaveworks/mike/render/simplify-pods
render/pod: Remove unused options and incorrect code
2017-07-04 20:38:45 +01:00
Matthias Radestock
d4d3e5f184 correct comment 2017-07-04 20:37:55 +01:00
Roland Schilter
718e817c73 Update README/Makefile/package.json to use yarn
Fixes #2606
2017-07-04 14:50:53 +02:00
Simon Howe
ba29271053 Prevents 6 digit pids from being truncated in details panel/table mode 2017-07-04 10:42:18 +02:00
Simon Howe
ee55d17b0e Review feedback on supporting multiple relatives in node-grid columns 2017-07-04 10:41:41 +02:00
Simon Howe
ffd531e44a Show multiple relatives in the nodes-grid view 2017-07-04 10:41:41 +02:00
Matthias Radestock
4dbb913ca2 refactor: remove dead Copy() code 2017-07-04 07:35:30 +01:00
Matthias Radestock
a6491a35c3 refactor: remove unnecessary Copy() code 2017-07-04 07:35:30 +01:00
Matthias Radestock
f0ae2bd98c refactor: use inline StringSet constructor 2017-07-04 06:29:19 +01:00
Alfonso Acosta
6c03540b1f Merge pull request #2659 from weaveworks/use-new-k8s-go-client
Use new k8s go client
2017-07-03 23:23:41 +02:00
Mike Lang
73b7641d9f render/pod: Remove unused code and options 2017-07-03 13:50:56 -07:00
Matthias Radestock
5a468ae91c Merge pull request #2671 from weaveworks/better-sets
rationalise report set usage
2017-07-03 21:25:16 +01:00
Alfonso Acosta
93b0bc82d3 Remove more unused dependencies 2017-07-03 20:20:34 +00:00
Alfonso Acosta
6ff872c4a4 Delete old client vendored dependencies 2017-07-03 20:20:32 +00:00