mirror of
https://github.com/weaveworks/scope.git
synced 2026-03-02 17:50:39 +00:00
don't show container count in host detail panel image list
The figure is inaccurate since it counts containers across all hosts. Getting the count correct is non-trivial, so it's better to not show the figure at all. NB: the count still shows up on mouse-over of the link, but that is defensible and not (very) confusing since the link represents the image, not the image on a particular host, and it's the same count that show up as the minor label in the container images view. Fixes #2681.
This commit is contained in:
@@ -175,10 +175,8 @@ var nodeSummaryGroupSpecs = []struct {
|
||||
{
|
||||
topologyID: report.ContainerImage,
|
||||
NodeSummaryGroup: NodeSummaryGroup{
|
||||
Label: "Container Images",
|
||||
Columns: []Column{
|
||||
{ID: report.Container, Label: "# Containers", DefaultSort: true, Datatype: "number"},
|
||||
},
|
||||
Label: "Container Images",
|
||||
Columns: []Column{},
|
||||
},
|
||||
},
|
||||
}
|
||||
|
||||
@@ -132,10 +132,8 @@ func TestMakeDetailedHostNode(t *testing.T) {
|
||||
{
|
||||
Label: "Container Images",
|
||||
TopologyID: "containers-by-image",
|
||||
Columns: []detailed.Column{
|
||||
{ID: report.Container, Label: "# Containers", DefaultSort: true, Datatype: "number"},
|
||||
},
|
||||
Nodes: []detailed.NodeSummary{containerImageNodeSummary},
|
||||
Columns: []detailed.Column{},
|
||||
Nodes: []detailed.NodeSummary{containerImageNodeSummary},
|
||||
},
|
||||
},
|
||||
Connections: []detailed.ConnectionsSummary{
|
||||
|
||||
Reference in New Issue
Block a user