Commit Graph

5622 Commits

Author SHA1 Message Date
Bryan Boreham
7dc7215a26 Refactor: improve readability based on review feedback 2020-01-23 15:04:51 +00:00
Bryan Boreham
de939cc39b tests: add an integration test to check connection thinning 2020-01-13 08:59:51 +00:00
Bryan Boreham
b7b245ed48 tests: connection subset testing
Utility functions to create fake sets of connections for testing, and
then exercising the subset filtering code to check that quantities
come out as expected.
2020-01-13 08:59:51 +00:00
Bryan Boreham
4c9cf138d6 ui: include skipped connection count in rendering 2020-01-13 08:53:47 +00:00
Bryan Boreham
de3c34ddc6 performance(probe): thin out many connections between the same point
The app will only show one line, regardless of how many connections we
have, so reduce the number to save bandwidth and rendering time.

We filter by choosing a modulus, e.g. send every connection that is a
multiple of 3, or 9, and so on. We avoid multiples of 2 because port
numbers are often a multiple of 2 or 4 for bit-encoding reasons.
2020-01-13 08:53:47 +00:00
Bryan Boreham
fc46ea17ee refactor(probe/ebpf): track connections by four-tuple+namespace
The previous code tracked only by four-tuple, which meant that two
connections with same address/port combinations in different namespace
would clash and one would get dropped.

Also previously the tuple was duplicated between the map key and
value, so we remove it from the value.

We only add the namespace in the case that the local address is
loopback, which matches how the rest of Scope treats addresses.
2020-01-13 08:53:47 +00:00
Bryan Boreham
9758c81736 comment: add explanatory comment on handleFdInstall() 2020-01-13 08:53:47 +00:00
Bryan Boreham
d57a4df3b2 enhancement(probe): debug message for initial connection 2020-01-13 08:53:47 +00:00
Bryan Boreham
2767e2b319 improvement: only record connections that we have a PID for 2020-01-13 08:53:47 +00:00
Bryan Boreham
a6da810261 refactor(probe): move host/pid encoding into addConnection() function 2020-01-13 08:53:47 +00:00
Bryan Boreham
8b1296c892 Merge pull request #3735 from weaveworks/more-rbac
Add more rbac permissions in the 'apps' group
2019-12-15 20:52:31 +00:00
Bryan Boreham
91eb720b8d Add more rbac permissions in the 'apps' group
Daemonset was missed in the update from v1beta1 to v1;
also we need get and update on deployments/scale.
2019-12-12 20:18:04 +00:00
Bryan Boreham
5ebe9b4b18 Merge pull request #3720 from DarthSett/master
Adding the "user-agent" Header
2019-11-26 11:19:36 +00:00
Bryan Boreham
5dc83325b9 Merge pull request #3729 from slalwani97/update-terminating-state
Update pod status to terminating
2019-11-26 11:13:28 +00:00
Sumit Lalwani
1ce7707f25 Update pod status to terminating
Signed-off-by: Sumit Lalwani <sumit.lalwani97@gmail.com>
2019-11-25 11:31:48 +05:30
Bryan Boreham
534505253f Merge pull request #3718 from weaveworks/release-1.12
Release 1.12.0
2019-11-12 17:50:06 +00:00
Bryan Boreham
d9082d2649 Release 1.12.0 v1.12.0 2019-11-12 17:20:19 +00:00
Daniel Holbach
056704e8cd Merge pull request #3726 from weaveworks/update-js-lib
Update js libs
2019-11-12 12:46:26 +01:00
Daniel Holbach
f27fdcda1a update a number of js libs 2019-11-12 10:58:55 +01:00
DarthSett
ccfd2f0427 Added test to check user-agent header 2019-10-28 19:34:22 +05:30
DarthSett
4eab46670e Update user-agent in probe/appclient/probe_config.go
Co-Authored-By: Filip Barl <filip.barl@gmail.com>
2019-10-25 19:31:17 +05:30
DarthSett
af31e30439 Add user-agent header 2019-10-25 12:33:35 +05:30
Bryan Boreham
1b78a035b7 Merge pull request #3719 from weaveworks/update-lodash
Consolidate all lodash versions to 4.17.15
2019-10-24 12:49:51 +01:00
“DarthSett”
7adc70c5a5 add the user-agent header 2019-10-23 16:35:57 +05:30
rahul agrawal
0000173c05 add the user-agent header 2019-10-23 16:31:59 +05:30
Bryan Boreham
b3485dd294 Consolidate all lodash versions to 4.17.15 2019-10-22 14:24:10 +00:00
Bryan Boreham
4bb2a435ae Merge pull request #3712 from weaveworks/3711-restart-sync
fix(probe/ebpf): feed initial connections synchronously on restart
2019-10-22 12:09:49 +01:00
Filip Barl
bb0a263db8 Merge pull request #3717 from chandankumar4/custom-plugin
(fix): Mount plugin volume to weave-scope-cluster-agent resource
2019-10-22 12:17:47 +02:00
Bryan Boreham
abefd967e6 Merge pull request #3716 from weaveworks/dont-save-shortcut-reports
performance(aws_collector): don't persist shortcut reports
2019-10-21 12:31:44 +01:00
chandan kumar
67c2dd581b Mount plugin volume to weave-scope-cluster-agent resource 2019-10-19 01:01:06 +05:30
Bryan Boreham
d516ed9883 performance(aws_collector): don't persist shortcut reports
Shortcut reports are sent to update the UI quickly, on events like a
container starting. We don't need to persist them in the time-travel
data since the same information will be covered by a regular report a
few seconds later.
2019-10-17 18:02:36 +00:00
Bryan Boreham
4a02171e83 Merge pull request #3713 from weaveworks/dns-nodes
Fix accidental rename of DNS to 'nodes'
2019-10-17 12:07:02 +01:00
Bryan Boreham
b9c71f30d6 Update comments based on review feedback 2019-10-17 10:38:58 +00:00
Bryan Boreham
6ccbd2d0cf Fix accidental rename of DNS to 'nodes'
In commit 951629af29 the `DNS` field was accidentally renamed in
serialised data to `nodes`.  Put it back, and also add a field to fix
up data coming from a probe with that fault.
2019-10-14 15:08:39 +00:00
Filip Barl
83f9d4ec8d Merge pull request #3635 from imazik/ui-build-fix
[fix] [make] update ui build to avoid yarn build fail after make.
2019-10-14 14:52:43 +02:00
Shovan Maity
95b231727e update build to run as current user
pass user and group id in docker run command to run it as current user

Signed-off-by: Shovan Maity <shovan.cse91@gmail.com>
2019-10-14 17:01:59 +05:30
Bryan Boreham
b9f10e9b73 refactor(probe/ebpf): make ebpf setup safer
It was possible for `t.ebpfTracker` to change underneath this code
while running on a background goroutine, so change it to take
`ebpfTracker` as a parameter.

While we're here, rename the functions to better match what they do.
2019-10-14 11:25:04 +00:00
Bryan Boreham
ae83c6545e fix(probe/ebpf): feed initial connections synchronously on restart
If we run `getInitialState()` async there is some chance we will see
another ebpf failure and call `useProcfs()` before `getInitialState()`
gets to the last line, whereupon it will crash on nil pointer.

Also it seems pointless to call `performEbpfTrack()` without waiting
for something to feed in, so I suspect this is what the original
author had in mind.

It will slow down this one `Report()` on machines with a lot of
processes or connections, but ebpfTracker restart is supposed to be a
rare event.
2019-10-14 08:22:25 +00:00
Filip Barl
86d83c658d Merge pull request #3708 from openebs/fix/docker-login-issue
Remove -e flag from docker login
2019-10-11 11:02:12 +02:00
Akash Srivastava
d97a091450 Remove -e flag from docker login
- Builds are failing because CI is not able to login to docker
because -e (email) flag is deprecated.

Signed-off-by: Akash Srivastava <akashsrivastava4927@gmail.com>
2019-10-11 00:51:37 +05:30
Filip Barl
cb446ab3e4 Merge pull request #3706 from bensooraj/k8s_example_fix
Fix for ImagePullBackOff error when running the k8s example
2019-10-10 20:46:44 +02:00
Ben Sooraj
23270fecc3 k8s example: updated elasticsearch's image tag from the default 'latest' to '7.4.0'
To fix the ImagePullBackOff error

Fixes #3401
2019-10-10 21:53:37 +05:30
Bryan Boreham
e9e05b2ba4 Merge pull request #3698 from weaveworks/update-backend-build
build: update CI to use Go 1.13
2019-10-10 12:32:07 +01:00
Bryan Boreham
43f6b96ee5 Merge pull request #3702 from weaveworks/report-api-details-error
fix: report http error if /api call fails
2019-10-10 12:31:38 +01:00
Filip Barl
916f121e78 Merge pull request #3705 from weaveworks/3434-fix-favicon-in-dev-mode
Fix favicon.ico in UI dev mode
2019-10-08 12:25:58 +02:00
Filip Barl
e7513fd10e Merge pull request #3704 from weaveworks/3811-import-fonts-only-in-standalone
Import fonts only in Scope standalone
2019-10-08 12:05:05 +02:00
Filip Barl
b5d7beaa97 Fix favicon.ico in UI dev mode 2019-10-08 12:00:58 +02:00
Filip Barl
39e48356b0 Import fonts only in Scope standalone 2019-10-08 11:24:11 +02:00
Akash Srivastava
4bafaa1f29 Merge pull request #3703 from weaveworks/allow-disable-plugins
feature: allow user to disable plugins via command-line flag
2019-10-08 13:52:24 +05:30
Filip Barl
f09f9af4b9 Merge pull request #3701 from oleggator/json-stable-stringify
scripts: replace JSON.stringify with json-stable-stringify
2019-10-07 17:12:57 +02:00