github/weave-scope
1
0
Fork 0
mirror of https://github.com/weaveworks/scope.git synced 2026-07-28 01:31:17 +00:00
Code Issues Packages Projects Releases Wiki Activity

Update comments based on review feedback

Browse Source
This commit is contained in:
Bryan Boreham
2019-10-17 10:38:58 +00:00
parent 6ccbd2d0cf
commit b9c71f30d6
1 changed files with 2 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
report/report.go
View File

@@ -189,7 +189,7 @@ type Report struct {
Job Topology
DNS DNSRecords `json:"DNS,omitempty" deepequal:"nil==empty"`
// For release 1.11.6, probes accidentally sent DNS records labeled "nodes".
// Backwards-compatibility for an accident in commit 951629a / release 1.11.6.
BugDNS DNSRecords `json:"nodes,omitempty"`
// Sampling data for this report.
@@ -547,6 +547,7 @@ func (r Report) upgradeNamespaces() Report {
func (r Report) upgradeDNSRecords() Report {
// For release 1.11.6, probes accidentally sent DNS records labeled "nodes".
// Translate the incorrect version here. Accident was in commit 951629a.
if len(r.BugDNS) > 0 {
r.DNS = r.BugDNS
r.BugDNS = nil