From b9c71f30d68c37debc38b1f2be2feb8bd4cef8be Mon Sep 17 00:00:00 2001 From: Bryan Boreham Date: Thu, 17 Oct 2019 10:38:58 +0000 Subject: [PATCH] Update comments based on review feedback --- report/report.go | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/report/report.go b/report/report.go index ceeced5d5..e47800b83 100644 --- a/report/report.go +++ b/report/report.go @@ -189,7 +189,7 @@ type Report struct { Job Topology DNS DNSRecords `json:"DNS,omitempty" deepequal:"nil==empty"` - // For release 1.11.6, probes accidentally sent DNS records labeled "nodes". + // Backwards-compatibility for an accident in commit 951629a / release 1.11.6. BugDNS DNSRecords `json:"nodes,omitempty"` // Sampling data for this report. @@ -547,6 +547,7 @@ func (r Report) upgradeNamespaces() Report { func (r Report) upgradeDNSRecords() Report { // For release 1.11.6, probes accidentally sent DNS records labeled "nodes". + // Translate the incorrect version here. Accident was in commit 951629a. if len(r.BugDNS) > 0 { r.DNS = r.BugDNS r.BugDNS = nil