Commit Graph

90 Commits

Author SHA1 Message Date
Tom Wilkie
0217351bb7 Add tests to catch bad pseudo node mapping. 2015-09-02 13:37:03 +00:00
Tom Wilkie
7cce17945f Add comment 2015-09-01 12:25:53 +00:00
Tom Wilkie
405c4c4cd7 Move sterilze to expect package; reuse in app. 2015-09-01 12:07:43 +00:00
Tom Wilkie
217775654a Merge pull request #411 from weaveworks/357-adjacencies-to-nodemetadata
Move Adjacency info inside the NodeMetadata struct
2015-09-01 12:18:19 +01:00
Peter Bourgon
66c597ecf9 Remove debug code that snuck in 2015-09-01 09:36:57 +02:00
Tom Wilkie
1f6b3d4a45 Move Adjacency info inside the NodeMetadata struct; move pseudo node generation to the probes. 2015-08-28 15:20:27 +00:00
Tom Wilkie
903a51397b Review feedback 2015-08-28 09:19:56 +00:00
Tom Wilkie
55c77c6a37 Enhance the containers topology with information directly joined from endpoints, via IP address foreign key. 2015-08-27 16:29:35 +00:00
Tom Wilkie
e4970f9214 Give mapping functions the ability to return multiple nodes. 2015-08-27 16:29:32 +00:00
Tom Wilkie
e7dc258119 Only group processes not in containers AND doing network IO into uncontained nodes. 2015-08-27 15:26:49 +00:00
Peter Bourgon
44e6fd2adb Merge pull request #399 from weaveworks/topology-copy
Moar functional: Topology Merge methods don't mutate the receiver
2015-08-27 17:05:12 +02:00
Alfonso Acosta
9ba37402cf Report/render both image and container labels
Daemon labels will have to wait since the go client (Docker API v1.14) doesn't support
them yet (daemon labels were exposed in Docker API v1.16)

See https://godoc.org/github.com/fsouza/go-dockerclient#Client.Info for details.
2015-08-27 09:45:30 +00:00
Alfonso Acosta
529aa3d84f Use a metadata key per docker label 2015-08-26 15:49:13 +00:00
Alfonso Acosta
e1c05012ca Report docker container labels and render them in the details pane 2015-08-26 13:38:53 +00:00
Tom Wilkie
1ad1197051 Review feedback 2015-08-26 13:00:33 +00:00
Peter Bourgon
775f0ede90 render: fixes for new merge semantics 2015-08-26 12:02:11 +01:00
Tom Wilkie
d8ac16d3f3 Gather container IP addresses from Docker and Weave, and apply them to nodes in the container topology. 2015-08-26 10:19:08 +00:00
Tom Wilkie
e9fad6136f Tag containers with WeaveDNS hostnames. 2015-08-25 16:41:56 +00:00
Alfonso Acosta
a3ecc34d33 Merge pull request #387 from weaveworks/origin-host-labels
Improve titles and context of tables in the details pane
2015-08-25 12:43:32 +01:00
Alfonso Acosta
11e5135d19 Address PR comment 2015-08-25 10:31:13 +00:00
Alfonso Acosta
d1126f911b Desambiguate Container associated to processes in details pane 2015-08-24 21:13:27 +00:00
Alfonso Acosta
117b0e190b Address PR comment 2015-08-24 18:51:12 +00:00
Alfonso Acosta
807b30bfe3 Figure out whether to show host tags in details pane from context 2015-08-24 18:40:24 +00:00
Tom Wilkie
498bfd4b18 Make pseudo nodes clickable. 2015-08-24 14:05:01 +00:00
Alfonso Acosta
75595a5519 Add useful information to table titles in details pane
Title modifications:
* "Origin Process" -> "Process \"name\" (pid)"
* "Origin Container" -> "Container \"name\" (pid)"
* "Origin Host" -> "Host \"name\""
* "Origin Container Image" -> "Container Image \"name\""
2015-08-21 16:37:12 +00:00
Alfonso Acosta
a01a7069b6 Make tables and addContainerTable consistent with the rest of the code 2015-08-21 15:30:56 +00:00
Alfonso Acosta
10199737e4 Add host context in the details pane
In situations when the details can refer to entities from multiple hosts
(e.g. container image) make explicit to what host we are referring to.
2015-08-21 15:19:30 +00:00
Alfonso Acosta
37307c26b9 Merge 'Connections' and 'Connection Details' in node details pane
* Now the Connections table appears at the end of the pane

* Connection details are expandable (still not implemented in the UI but backwards
compatible).
2015-08-21 10:11:39 +00:00
Alfonso Acosta
c78f9d812c Add Expandable attribute to detailed-pane rows 2015-08-20 15:26:23 +00:00
Tom Wilkie
4bcdfc507f Typo 2015-08-19 15:04:56 +00:00
Tom Wilkie
08e1090a65 Merge pull request #369 from weaveworks/336-show-counts
Show how many containers have been grouped together under an image
2015-08-19 15:42:00 +01:00
Tom Wilkie
7508df7e5b Add NodeMetadata.Counters with appropriate merge semantics 2015-08-19 14:24:21 +00:00
Tom Wilkie
336ba79f95 Merge pull request #355 from weaveworks/directionality
Make edge direction flow from client->server.
2015-08-19 14:21:13 +01:00
Tom Wilkie
2b7b0c3774 Merge pull request #366 from weaveworks/331-process-container-names
Add container names to process minor label if possible.
2015-08-19 14:19:41 +01:00
Tom Wilkie
6f1f453098 Review feedback 2015-08-19 12:22:28 +00:00
Tom Wilkie
7fb1a98eca Update detail node logic to deal with connection directionality; also correctly merge edge metadata for pseudo nodes. 2015-08-19 10:21:01 +00:00
Tom Wilkie
60d1b503c1 Deal with directed edges in the rest of the codebase. 2015-08-19 10:17:31 +00:00
Tom Wilkie
0cc3dd0eea Merge pull request #367 from weaveworks/323-origin-address
Condense origin address entries into a single table.
2015-08-19 11:16:00 +01:00
Tom Wilkie
75369acb42 Review feedback 2015-08-19 10:06:57 +00:00
Tom Wilkie
fbe010a15f Review feedback 2015-08-19 09:24:52 +00:00
Peter Bourgon
a1b0088bf3 Remove (comm) from Name field in detail pane 2015-08-19 11:07:31 +02:00
Tom Wilkie
8c4bbdae8c Show how many containers have been grouped together under an image 2015-08-18 12:47:44 +00:00
Tom Wilkie
4efa811ef8 Add test. 2015-08-18 12:16:42 +00:00
Tom Wilkie
a86d47deb0 Add container names to process minor label if possible. 2015-08-18 11:24:48 +00:00
Tom Wilkie
89831bfdd2 Condense origin address entries into a single table. 2015-08-18 11:23:45 +00:00
Peter Bourgon
0dafad763f Calculate rates in detailed nodes 2015-08-03 16:04:06 +02:00
Peter Bourgon
e1f7752a34 Split PacketCount to Egress and Ingress
Also, 1 packet may be counted in N topologies, so you can't rely on the
sum of all packet counts across topologies having any relation to the
sampling data.
2015-08-03 14:58:41 +02:00
Peter Bourgon
0361b11b87 Fix bugs in how we report bandwidth 2015-08-03 12:25:56 +02:00
Peter Bourgon
0aadf6447b Revert to correct edge construction
Another implicit invariant in the data model is that edges are always of the
form (local -> remote). That is, the source of an edge must always be a node
that originates from within Scope's domain of visibility. This was evident by
the presence of ingress and egress fields in edge/aggregate metadata.

When building the sniffer, I accidentally and incorrectly violated this
invariant, by constructing distinct edges for (local -> remote) and (remote ->
local), and collapsing ingress and egress byte counts to a single scalar. I
experienced a variety of subtle undefined behavior as a result. See #339.

This change reverts to the old, correct methodology. Consequently the sniffer
needs to be able to find out which side of the sniffed packet is local v.
remote, and to do that it needs access to local networks. I moved the
discovery from the probe/host package into probe/main.go.

As part of that work I discovered that package report also maintains its own,
independent "cache" of local networks. Except it contains only the (optional)
Docker bridge network, if it's been populated by the probe, and it's only used
by the report.Make{Endpoint,Address}NodeID constructors to scope local
addresses. Normally, scoping happens during rendering, and only for pseudo
nodes -- see current LeafMap Render localNetworks. This is pretty convoluted
and should be either be made consistent or heavily commented.
2015-08-03 10:55:59 +02:00
Peter Bourgon
b9afa67ad6 gopacket-based traffic sniffing 2015-08-03 10:55:59 +02:00