Review feedback

This commit is contained in:
Tom Wilkie
2015-08-19 09:24:52 +00:00
parent 819cfdfbdd
commit fbe010a15f
2 changed files with 9 additions and 5 deletions

View File

@@ -62,10 +62,8 @@ func TestAll(t *testing.T) {
}
}
func TestAPITopologyApplications(t *testing.T) {
func TestAPITopologyContainers(t *testing.T) {
ts := httptest.NewServer(Router(StaticReport{}))
defer ts.Close()
is404(t, ts, "/api/topology/applications/foobar")
{
body := getRawJSON(t, ts, "/api/topology/containers")
var topo APITopology
@@ -77,6 +75,12 @@ func TestAPITopologyApplications(t *testing.T) {
t.Error(test.Diff(want, have))
}
}
}
func TestAPITopologyApplications(t *testing.T) {
ts := httptest.NewServer(Router(StaticReport{}))
defer ts.Close()
is404(t, ts, "/api/topology/applications/foobar")
{
body := getRawJSON(t, ts, "/api/topology/applications/"+expected.ServerProcessID)
var node APINode

View File

@@ -36,8 +36,8 @@ type ProcessWithContainerNameRenderer struct{}
// Render produces a process graph where the minor labels contain the
// container name, if found.
func (r ProcessWithContainerNameRenderer) Render(rpt report.Report) RenderableNodes {
var processes = ProcessRenderer.Render(rpt)
var containers = LeafMap{
processes := ProcessRenderer.Render(rpt)
containers := LeafMap{
Selector: report.SelectContainer,
Mapper: MapContainerIdentity,
Pseudo: PanicPseudoNode,