github/weave-scope
1
0
Fork 0
mirror of https://github.com/weaveworks/scope.git synced 2026-07-19 05:19:35 +00:00
Code Issues Packages Projects Releases Wiki Activity

make it possible for users to see unconnected processes

Browse Source 
We prevented this because rendering them was expensive. It still is,
but less so and actually works well, especially in table mode.
This commit is contained in:
Matthias Radestock
2018-01-02 09:40:18 +00:00
parent 74c72945ef
commit ec7c468758
1 changed files with 4 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
app/api_topologies.go
View File

@@ -188,9 +188,8 @@ func MakeRegistry() *Registry {
ID: "unconnected",
Default: "hide",
Options: []APITopologyOption{
// Show the user why there are filtered nodes in this view.
// Don't give them the option to show those nodes.
{Value: "hide", Label: "Unconnected nodes hidden", filter: nil, filterPseudo: false},
{Value: "show", Label: "Show Unconnected", filter: nil, filterPseudo: false},
{Value: "hide", Label: "Hide Unconnected", filter: render.IsConnected, filterPseudo: false},
},
},
}
@@ -201,7 +200,7 @@ func MakeRegistry() *Registry {
APITopologyDesc{
id: processesID,
renderer: render.ProcessWithContainerNameRenderer,
filter: render.FilterUnconnected,
filter: render.FilterUnconnectedPseudo,
Name: "Processes",
Rank: 1,
Options: unconnectedFilter,
@@ -211,7 +210,7 @@ func MakeRegistry() *Registry {
id: processesByNameID,
parent: processesID,
renderer: render.ProcessNameRenderer,
filter: render.FilterUnconnected,
filter: render.FilterUnconnectedPseudo,
Name: "by name",
Options: unconnectedFilter,
HideIfEmpty: true,