From ec7c468758cd90339ff0452bf7a68104c0411024 Mon Sep 17 00:00:00 2001 From: Matthias Radestock Date: Tue, 2 Jan 2018 09:40:18 +0000 Subject: [PATCH] make it possible for users to see unconnected processes We prevented this because rendering them was expensive. It still is, but less so and actually works well, especially in table mode. --- app/api_topologies.go | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/app/api_topologies.go b/app/api_topologies.go index 1d205ce60..6f5dd3fc6 100644 --- a/app/api_topologies.go +++ b/app/api_topologies.go @@ -188,9 +188,8 @@ func MakeRegistry() *Registry { ID: "unconnected", Default: "hide", Options: []APITopologyOption{ - // Show the user why there are filtered nodes in this view. - // Don't give them the option to show those nodes. - {Value: "hide", Label: "Unconnected nodes hidden", filter: nil, filterPseudo: false}, + {Value: "show", Label: "Show Unconnected", filter: nil, filterPseudo: false}, + {Value: "hide", Label: "Hide Unconnected", filter: render.IsConnected, filterPseudo: false}, }, }, } @@ -201,7 +200,7 @@ func MakeRegistry() *Registry { APITopologyDesc{ id: processesID, renderer: render.ProcessWithContainerNameRenderer, - filter: render.FilterUnconnected, + filter: render.FilterUnconnectedPseudo, Name: "Processes", Rank: 1, Options: unconnectedFilter, @@ -211,7 +210,7 @@ func MakeRegistry() *Registry { id: processesByNameID, parent: processesID, renderer: render.ProcessNameRenderer, - filter: render.FilterUnconnected, + filter: render.FilterUnconnectedPseudo, Name: "by name", Options: unconnectedFilter, HideIfEmpty: true,