github/weave-scope
1
0
Fork 0
mirror of https://github.com/weaveworks/scope.git synced 2026-03-03 02:00:43 +00:00
Code Issues Packages Projects Releases Wiki Activity

Tidyup JS: make keys in grouping dict more sensible

Browse Source 
true/false are confusing.
This commit is contained in:
Simon Howe
2016-08-03 17:25:09 +02:00
parent 6c0f8ba638
commit d02cb25495
1 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
client/app/scripts/components/node-details/node-details-table.js
View File

@@ -105,10 +105,10 @@ function getSortedNodes(nodes, columns, sortBy, sortedDesc) {
const getValue = getValueForSortBy(sortBy || getDefaultSortBy(columns, nodes));
const withAndWithoutValues = _.groupBy(nodes, (n) => {
const v = getValue(n);
return v !== null && v !== undefined;
return v !== null && v !== undefined ? 'withValues' : 'withoutValues';
});
const withValues = sortNodes(withAndWithoutValues.true, columns, sortBy, sortedDesc);
const withoutValues = sortNodes(withAndWithoutValues.false, columns, sortBy, sortedDesc);
const withValues = sortNodes(withAndWithoutValues.withValues, columns, sortBy, sortedDesc);
const withoutValues = sortNodes(withAndWithoutValues.withoutValues, columns, sortBy, sortedDesc);
return _.concat(withValues, withoutValues);
}