From d02cb25495484ba907610c38c2144c8be13e6cad Mon Sep 17 00:00:00 2001 From: Simon Howe Date: Wed, 3 Aug 2016 17:25:09 +0200 Subject: [PATCH] Tidyup JS: make keys in grouping dict more sensible true/false are confusing. --- .../scripts/components/node-details/node-details-table.js | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/client/app/scripts/components/node-details/node-details-table.js b/client/app/scripts/components/node-details/node-details-table.js index fa3b81eda..ba09c3003 100644 --- a/client/app/scripts/components/node-details/node-details-table.js +++ b/client/app/scripts/components/node-details/node-details-table.js @@ -105,10 +105,10 @@ function getSortedNodes(nodes, columns, sortBy, sortedDesc) { const getValue = getValueForSortBy(sortBy || getDefaultSortBy(columns, nodes)); const withAndWithoutValues = _.groupBy(nodes, (n) => { const v = getValue(n); - return v !== null && v !== undefined; + return v !== null && v !== undefined ? 'withValues' : 'withoutValues'; }); - const withValues = sortNodes(withAndWithoutValues.true, columns, sortBy, sortedDesc); - const withoutValues = sortNodes(withAndWithoutValues.false, columns, sortBy, sortedDesc); + const withValues = sortNodes(withAndWithoutValues.withValues, columns, sortBy, sortedDesc); + const withoutValues = sortNodes(withAndWithoutValues.withoutValues, columns, sortBy, sortedDesc); return _.concat(withValues, withoutValues); }