github/weave-scope
1
0
Fork 0
mirror of https://github.com/weaveworks/scope.git synced 2026-08-18 03:46:45 +00:00
Code Issues Packages Projects Releases Wiki Activity

comment: clarify memcached error cases

Browse Source
This commit is contained in:
Bryan Boreham
2020-04-15 16:49:02 +00:00
parent 9a739fda46
commit b1fc59819a
1 changed files with 5 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
app/multitenant/aws_collector.go
+5 -1
View File
@@ -587,6 +587,9 @@ func (c *awsCollector) persistReport(ctx context.Context, userid, rowKey, colKey
if c.cfg.MemcacheClient != nil {
_, err = c.cfg.MemcacheClient.StoreReportBytes(ctx, reportKey, buf)
if err != nil {
// NOTE: We don't abort here because failing to store in memcache
// doesn't actually break anything else -- it's just an
// optimization.
log.Warningf("Could not store %v in memcache: %v", reportKey, err)
}
}
@@ -666,7 +669,8 @@ func (c *awsCollector) Add(ctx context.Context, rep report.Report, buf []byte) e
_, _, reportKey := calculateReportKeys(userid, time.Now())
_, err = c.cfg.MemcacheClient.StoreReportBytes(ctx, reportKey, buf)
if err != nil {
log.Warningf("Could not store %v in memcache: %v", reportKey, err)
log.Warningf("Could not store shortcut %v in memcache: %v", reportKey, err)
// No point publishing on nats if cache store failed
return nil
}
err := c.nats.Publish(userid, []byte(reportKey))