From b1fc59819ac7396590088074c5233a0c6b886dec Mon Sep 17 00:00:00 2001 From: Bryan Boreham Date: Wed, 15 Apr 2020 16:49:02 +0000 Subject: [PATCH] comment: clarify memcached error cases --- app/multitenant/aws_collector.go | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/app/multitenant/aws_collector.go b/app/multitenant/aws_collector.go index 11b4a5ae0..dc3364e8e 100644 --- a/app/multitenant/aws_collector.go +++ b/app/multitenant/aws_collector.go @@ -587,6 +587,9 @@ func (c *awsCollector) persistReport(ctx context.Context, userid, rowKey, colKey if c.cfg.MemcacheClient != nil { _, err = c.cfg.MemcacheClient.StoreReportBytes(ctx, reportKey, buf) if err != nil { + // NOTE: We don't abort here because failing to store in memcache + // doesn't actually break anything else -- it's just an + // optimization. log.Warningf("Could not store %v in memcache: %v", reportKey, err) } } @@ -666,7 +669,8 @@ func (c *awsCollector) Add(ctx context.Context, rep report.Report, buf []byte) e _, _, reportKey := calculateReportKeys(userid, time.Now()) _, err = c.cfg.MemcacheClient.StoreReportBytes(ctx, reportKey, buf) if err != nil { - log.Warningf("Could not store %v in memcache: %v", reportKey, err) + log.Warningf("Could not store shortcut %v in memcache: %v", reportKey, err) + // No point publishing on nats if cache store failed return nil } err := c.nats.Publish(userid, []byte(reportKey))