github/vim-ale
1
0
Fork 0
mirror of https://github.com/webinstall/webi-installers.git synced 2026-04-06 18:36:50 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: use API URLs for source tarballs, match legacy filename pattern

Browse Source 
Source-only GitHub releases now use the API-provided tarball_url
and zipball_url directly. Filename follows the legacy pattern
(Owner-Repo-Tag.ext) to approximate the Content-Disposition
filename that Node.js gets by following the redirect.
This commit is contained in:
AJ ONeal
2026-03-10 17:17:35 -06:00
parent 4a9088fea7
commit d56f43e3b4
1 changed files with 11 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
cmd/webicached/main.go
View File

@@ -585,11 +585,20 @@ func classifyGitHub(pkg string, conf *installerconf.Conf, d *rawcache.Dir) ([]st
// Releases with no uploaded assets are source-only — use the
// API-provided tarball/zipball URLs. These can also be installed
// via `git clone --branch <tag>` as a fallback.
//
// The API's tarball_url redirects to:
// codeload.github.com/{owner}/{repo}/legacy.tar.gz/refs/tags/{tag}
// which serves Content-Disposition with a filename like:
// Owner-Repo-Tag-0-gCommitHash.tar.gz
// We use the API URL directly and construct the legacy filename
// pattern (without the commit hash, which isn't in the API data).
if len(rel.Assets) == 0 {
owner := conf.Owner
repo := conf.Repo
tag := rel.TagName
if rel.TarballURL != "" {
assets = append(assets, storage.Asset{
Filename: tag + ".tar.gz",
Filename: owner + "-" + repo + "-" + tag + ".tar.gz",
Version: version,
Channel: channel,
OS: "posix_2017",
@@ -601,7 +610,7 @@ func classifyGitHub(pkg string, conf *installerconf.Conf, d *rawcache.Dir) ([]st
}
if rel.ZipballURL != "" {
assets = append(assets, storage.Asset{
Filename: tag + ".zip",
Filename: owner + "-" + repo + "-" + tag + ".zip",
Version: version,
Channel: channel,
OS: "posix_2017",