github/vim-ale
1
0
Fork 0
mirror of https://github.com/webinstall/webi-installers.git synced 2026-04-06 18:36:50 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: use GitHub API tarball/zipball URLs instead of constructing them

Browse Source 
Source-only releases now use the API-provided tarball_url and
zipball_url directly instead of guessing the archive URL format.
The filename uses the git tag, and the download URL is what
GitHub's API actually returns.
This commit is contained in:
AJ ONeal
2026-03-10 17:13:04 -06:00
parent 9f3e9445dc
commit 4a9088fea7
1 changed files with 7 additions and 18 deletions
Download Patch File Download Diff File Expand all files Collapse all files

25
cmd/webicached/main.go
View File

@@ -582,43 +582,32 @@ func classifyGitHub(pkg string, conf *installerconf.Conf, d *rawcache.Dir) ([]st
// These are installable on any POSIX system (shell scripts, etc.).
//
// GitHub has two archive URL formats:
// legacy: codeload.github.com/{owner}/{repo}/legacy.tar.gz/refs/tags/{tag}
// → filename: Owner-Repo-Tag-0-gHash.tar.gz
// → extracts: Owner-Repo-Hash/
// current: codeload.github.com/{owner}/{repo}/tar.gz/refs/tags/{tag}
// → filename: repo-version.tar.gz
// → extracts: repo-version/
//
// The API's tarball_url/zipball_url redirect to the legacy format.
// We use the current format: cleaner names, consistent directory.
// Releases with no uploaded assets are source-only — use the
// API-provided tarball/zipball URLs. These can also be installed
// via `git clone --branch <tag>` as a fallback.
if len(rel.Assets) == 0 {
repo := conf.Repo
tag := rel.TagName
// Strip leading "v" for the version used in the filename/dir.
tagVer := strings.TrimPrefix(tag, "v")
if rel.TarballURL != "" {
dlURL := fmt.Sprintf("https://github.com/%s/%s/archive/refs/tags/%s.tar.gz", conf.Owner, repo, tag)
assets = append(assets, storage.Asset{
Filename: repo + "-" + tagVer + ".tar.gz",
Filename: tag + ".tar.gz",
Version: version,
Channel: channel,
OS: "posix_2017",
Arch: "*",
Format: ".tar.gz",
Download: dlURL,
Download: rel.TarballURL,
Date: date,
})
}
if rel.ZipballURL != "" {
dlURL := fmt.Sprintf("https://github.com/%s/%s/archive/refs/tags/%s.zip", conf.Owner, repo, tag)
assets = append(assets, storage.Asset{
Filename: repo + "-" + tagVer + ".zip",
Filename: tag + ".zip",
Version: version,
Channel: channel,
OS: "posix_2017",
Arch: "*",
Format: ".zip",
Download: dlURL,
Download: rel.ZipballURL,
Date: date,
})
}