Merge pull request #487 from replicatedhq/emosbaugh/20211130/fixes

Various fixes

config/samples/troubleshoot_v1beta2_collector.yaml

@@ -15,7 +15,7 @@ spec:
     #       - name=nginx-ingress-microk8s
     #     namespace: default
     #     limits:
-    #       maxAge: 30d
+    #       maxAge: 720h # 30*24
     #       maxLines: 10000
     # - run:
     #     collectorName: ping-google

examples/support-bundle/sample-supportbundle.yaml

@@ -10,7 +10,7 @@ spec:
           - component=nginx
         namespace: repl{{ Namespace }}
         limits:
-          maxAge: 30d
+          maxAge: 720h # 30*24
           maxLines: 10000
   analyzers:
     - clusterVersion:

pkg/analyze/crd.go

@@ -30,8 +30,8 @@ func analyzeCustomResourceDefinition(analyzer *troubleshootv1beta2.CustomResourc
 		IconURI: "https://troubleshoot.sh/images/analyzer-icons/custom-resource-definition.svg?w=13&h=16",
 	}
 
-	for _, storageClass := range crds {
-		if storageClass.Name == analyzer.CustomResourceDefinitionName {
+	for _, crd := range crds {
+		if crd.Name == analyzer.CustomResourceDefinitionName {
 			result.IsPass = true
 			for _, outcome := range analyzer.Outcomes {
 				if outcome.Pass != nil {

pkg/analyze/image_pull_secret.go

@@ -61,7 +61,7 @@ func analyzeImagePullSecret(analyzer *troubleshootv1beta2.ImagePullSecret, getCh
 		if result.IsPass {
 			result.Message = fmt.Sprintf("Credentials to pull from: %s found", analyzer.RegistryName)
 		} else {
-			result.Message = fmt.Sprintf("Credentials to pull from: %s not ound", analyzer.RegistryName)
+			result.Message = fmt.Sprintf("Credentials to pull from: %s not found", analyzer.RegistryName)
 		}
 	}
 	return &result, nil