From 213d518136184b14ce315e91ca318b855974fa16 Mon Sep 17 00:00:00 2001 From: Ethan Mosbaugh Date: Tue, 30 Nov 2021 20:11:51 +0000 Subject: [PATCH 1/3] Time parse doesnt support day notation --- config/samples/troubleshoot_v1beta2_collector.yaml | 2 +- examples/support-bundle/sample-supportbundle.yaml | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/config/samples/troubleshoot_v1beta2_collector.yaml b/config/samples/troubleshoot_v1beta2_collector.yaml index 7f2de496..b3b8e008 100644 --- a/config/samples/troubleshoot_v1beta2_collector.yaml +++ b/config/samples/troubleshoot_v1beta2_collector.yaml @@ -15,7 +15,7 @@ spec: # - name=nginx-ingress-microk8s # namespace: default # limits: - # maxAge: 30d + # maxAge: 720h # 30*24 # maxLines: 10000 # - run: # collectorName: ping-google diff --git a/examples/support-bundle/sample-supportbundle.yaml b/examples/support-bundle/sample-supportbundle.yaml index 63d75d09..40dbc67d 100644 --- a/examples/support-bundle/sample-supportbundle.yaml +++ b/examples/support-bundle/sample-supportbundle.yaml @@ -10,7 +10,7 @@ spec: - component=nginx namespace: repl{{ Namespace }} limits: - maxAge: 30d + maxAge: 720h # 30*24 maxLines: 10000 analyzers: - clusterVersion: From 4d0eaf471f9f80c21216cc0cee670a940fc5abb0 Mon Sep 17 00:00:00 2001 From: Ethan Mosbaugh Date: Tue, 30 Nov 2021 20:12:09 +0000 Subject: [PATCH 2/3] crd not storageClass --- pkg/analyze/crd.go | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/pkg/analyze/crd.go b/pkg/analyze/crd.go index 45f8e521..e967cb81 100644 --- a/pkg/analyze/crd.go +++ b/pkg/analyze/crd.go @@ -30,8 +30,8 @@ func analyzeCustomResourceDefinition(analyzer *troubleshootv1beta2.CustomResourc IconURI: "https://troubleshoot.sh/images/analyzer-icons/custom-resource-definition.svg?w=13&h=16", } - for _, storageClass := range crds { - if storageClass.Name == analyzer.CustomResourceDefinitionName { + for _, crd := range crds { + if crd.Name == analyzer.CustomResourceDefinitionName { result.IsPass = true for _, outcome := range analyzer.Outcomes { if outcome.Pass != nil { From fba0f9722559e639f42bbb461e9576bb777a1e33 Mon Sep 17 00:00:00 2001 From: Ethan Mosbaugh Date: Tue, 30 Nov 2021 20:12:29 +0000 Subject: [PATCH 3/3] found not ound --- pkg/analyze/image_pull_secret.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pkg/analyze/image_pull_secret.go b/pkg/analyze/image_pull_secret.go index 264bd78e..2c773ae3 100644 --- a/pkg/analyze/image_pull_secret.go +++ b/pkg/analyze/image_pull_secret.go @@ -61,7 +61,7 @@ func analyzeImagePullSecret(analyzer *troubleshootv1beta2.ImagePullSecret, getCh if result.IsPass { result.Message = fmt.Sprintf("Credentials to pull from: %s found", analyzer.RegistryName) } else { - result.Message = fmt.Sprintf("Credentials to pull from: %s not ound", analyzer.RegistryName) + result.Message = fmt.Sprintf("Credentials to pull from: %s not found", analyzer.RegistryName) } } return &result, nil