Publish image on tag

As we are pretty much committed to github actions, we should
probably rely on it to push the images on tag.

This covers the missing bits.

.circleci/config.yml

@@ -1,28 +0,0 @@
-version: 2
-jobs:
-  build:
-    docker:
-      - image: cimg/go:1.15
-    steps:
-      - checkout
-      - setup_remote_docker
-      - deploy:
-          name: Build and push image
-          command: |
-            echo "$DOCKER_PASS" | docker login --username "$DOCKER_USER" --password-stdin
-            if [ -z "${CIRCLE_TAG}" ]; then
-                make publish-image
-            else
-                make VERSION="${CIRCLE_TAG}" publish-image
-            fi
-
-workflows:
-  version: 2
-  build:
-    jobs:
-     - build:
-         filters:
-           tags:
-             only: /.*/
-           branches:
-             ignore: gh-pages

.github/workflows/on-tag.yaml

@@ -24,7 +24,17 @@ jobs:
           go-version: "${{ steps.awk_gomod.outputs.version }}"
       - run: |
           make DH_ORG="${{ github.repository_owner }}" VERSION="${GITHUB_REF#refs/tags/}" image
+
       - uses: Azure/container-scan@v0
         with:
           image-name: docker.io/${{ github.repository_owner }}/kured:${GITHUB_REF#refs/tags/}
-      # We should add a step to publish the image on tag.
+
+      - name: Login to DockerHub
+        uses: docker/login-action@v1
+        with:
+          username: ${{ secrets.DOCKERHUB_USERNAME }}
+          password: ${{ secrets.DOCKERHUB_TOKEN }}
+
+      - name: Publish image
+        run: |
+          make DH_ORG="${{ github.repository_owner }}" VERSION="${GITHUB_REF#refs/tags/}" publish-image

README.md

@@ -283,8 +283,7 @@ Using `--lock-ttl=30m` will allow other nodes to take over if TTL has expired (i
 
 ## Building
 
-See the [CircleCI config](.circleci/config.yml) for the preferred
-version of Golang. Kured now uses [Go
+Kured now uses [Go
 Modules](https://github.com/golang/go/wiki/Modules), so build
 instructions vary depending on where you have checked out the
 repository: