From ea5767337332d3b7dd494a339b26a15cc6524e4c Mon Sep 17 00:00:00 2001
From: Jean-Philippe Evrard <open-source@a.spamming.party>
Date: Mon, 30 Nov 2020 14:23:45 +0100
Subject: [PATCH] Publish image on tag

As we are pretty much committed to github actions, we should
probably rely on it to push the images on tag.

This covers the missing bits.
---
 .circleci/config.yml          | 28 ----------------------------
 .github/workflows/on-tag.yaml | 12 +++++++++++-
 README.md                     |  3 +--
 3 files changed, 12 insertions(+), 31 deletions(-)
 delete mode 100644 .circleci/config.yml

diff --git a/.circleci/config.yml b/.circleci/config.yml
deleted file mode 100644
index cb72179..0000000
--- a/.circleci/config.yml
+++ /dev/null
@@ -1,28 +0,0 @@
-version: 2
-jobs:
-  build:
-    docker:
-      - image: cimg/go:1.15
-    steps:
-      - checkout
-      - setup_remote_docker
-      - deploy:
-          name: Build and push image
-          command: |
-            echo "$DOCKER_PASS" | docker login --username "$DOCKER_USER" --password-stdin
-            if [ -z "${CIRCLE_TAG}" ]; then
-                make publish-image
-            else
-                make VERSION="${CIRCLE_TAG}" publish-image
-            fi
-
-workflows:
-  version: 2
-  build:
-    jobs:
-     - build:
-         filters:
-           tags:
-             only: /.*/
-           branches:
-             ignore: gh-pages
diff --git a/.github/workflows/on-tag.yaml b/.github/workflows/on-tag.yaml
index c6b23e9..c72c33f 100644
--- a/.github/workflows/on-tag.yaml
+++ b/.github/workflows/on-tag.yaml
@@ -24,7 +24,17 @@ jobs:
           go-version: "${{ steps.awk_gomod.outputs.version }}"
       - run: |
           make DH_ORG="${{ github.repository_owner }}" VERSION="${GITHUB_REF#refs/tags/}" image
+
       - uses: Azure/container-scan@v0
         with:
           image-name: docker.io/${{ github.repository_owner }}/kured:${GITHUB_REF#refs/tags/}
-      # We should add a step to publish the image on tag.
+
+      - name: Login to DockerHub
+        uses: docker/login-action@v1
+        with:
+          username: ${{ secrets.DOCKERHUB_USERNAME }}
+          password: ${{ secrets.DOCKERHUB_TOKEN }}
+
+      - name: Publish image
+        run: |
+          make DH_ORG="${{ github.repository_owner }}" VERSION="${GITHUB_REF#refs/tags/}" publish-image
diff --git a/README.md b/README.md
index f82b228..cce277a 100644
--- a/README.md
+++ b/README.md
@@ -283,8 +283,7 @@ Using `--lock-ttl=30m` will allow other nodes to take over if TTL has expired (i
 
 ## Building
 
-See the [CircleCI config](.circleci/config.yml) for the preferred
-version of Golang. Kured now uses [Go
+Kured now uses [Go
 Modules](https://github.com/golang/go/wiki/Modules), so build
 instructions vary depending on where you have checked out the
 repository: