github/kubevela
1
0
Fork 0
mirror of https://github.com/kubevela/kubevela.git synced 2026-08-27 16:17:34 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix componentDefinition ignore error bug (#1567)

Browse Source
This commit is contained in:
wyike
2021-04-26 19:20:04 +08:00
committed by GitHub
parent 396f244af1
commit f625877eb1
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
pkg/controller/core.oam.dev/v1alpha2/core/components/componentdefinition/componentdefinition_controller.go
+1 -1
View File
@@ -160,7 +160,7 @@ func (r *Reconciler) Reconcile(req ctrl.Request) (ctrl.Result, error) {
if err := r.Status().Update(ctx, &def.ComponentDefinition); err != nil {
klog.ErrorS(err, "cannot update componentDefinition Status")
r.record.Event(&(def.ComponentDefinition), event.Warning("cannot update ComponentDefinition Status", err))
return ctrl.Result{}, nil
return ctrl.Result{}, err
}
if err := coredef.CleanUpDefinitionRevision(ctx, r.Client, &def.ComponentDefinition, r.defRevLimit); err != nil {