diff --git a/pkg/controller/core.oam.dev/v1alpha2/core/components/componentdefinition/componentdefinition_controller.go b/pkg/controller/core.oam.dev/v1alpha2/core/components/componentdefinition/componentdefinition_controller.go index ba5927379..6b63cfc2a 100644 --- a/pkg/controller/core.oam.dev/v1alpha2/core/components/componentdefinition/componentdefinition_controller.go +++ b/pkg/controller/core.oam.dev/v1alpha2/core/components/componentdefinition/componentdefinition_controller.go @@ -160,7 +160,7 @@ func (r *Reconciler) Reconcile(req ctrl.Request) (ctrl.Result, error) { if err := r.Status().Update(ctx, &def.ComponentDefinition); err != nil { klog.ErrorS(err, "cannot update componentDefinition Status") r.record.Event(&(def.ComponentDefinition), event.Warning("cannot update ComponentDefinition Status", err)) - return ctrl.Result{}, nil + return ctrl.Result{}, err } if err := coredef.CleanUpDefinitionRevision(ctx, r.Client, &def.ComponentDefinition, r.defRevLimit); err != nil {