github/kubevela
1
0
Fork 0
mirror of https://github.com/kubevela/kubevela.git synced 2026-08-19 04:26:39 +00:00
Code Issues Packages Projects Releases Wiki Activity

skip applying helm-release if app spec not change (#1461)

Browse Source 
Signed-off-by: roywang <seiwy2010@gmail.com>
This commit is contained in:
Yue Wang
2021-04-11 15:47:00 +08:00
committed by GitHub
parent bc6a60dde2
commit 7edfbde2f5
1 changed files with 3 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
pkg/controller/core.oam.dev/v1alpha2/application/apply.go
+3 -2
View File
@@ -154,8 +154,9 @@ func (h *appHandler) apply(ctx context.Context, appRev *v1beta1.ApplicationRevis
}
}
}
if comp.Spec.Helm != nil {
// TODO(wonderflow): do we still need to apply helm resource if the spec has no difference?
// isNewRevision indicates app's newly created or spec has changed
// skip applying helm resources if no spec change
if h.isNewRevision && comp.Spec.Helm != nil {
if err = h.applyHelmModuleResources(ctx, comp, owners); err != nil {
return errors.Wrap(err, "cannot apply Helm module resources")
}