From 7edfbde2f5b45d6bff79d1f5bc13bc19581e757a Mon Sep 17 00:00:00 2001 From: Yue Wang Date: Sun, 11 Apr 2021 16:47:00 +0900 Subject: [PATCH] skip applying helm-release if app spec not change (#1461) Signed-off-by: roywang --- pkg/controller/core.oam.dev/v1alpha2/application/apply.go | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/pkg/controller/core.oam.dev/v1alpha2/application/apply.go b/pkg/controller/core.oam.dev/v1alpha2/application/apply.go index f1351137b..b515f2c2c 100644 --- a/pkg/controller/core.oam.dev/v1alpha2/application/apply.go +++ b/pkg/controller/core.oam.dev/v1alpha2/application/apply.go @@ -154,8 +154,9 @@ func (h *appHandler) apply(ctx context.Context, appRev *v1beta1.ApplicationRevis } } } - if comp.Spec.Helm != nil { - // TODO(wonderflow): do we still need to apply helm resource if the spec has no difference? + // isNewRevision indicates app's newly created or spec has changed + // skip applying helm resources if no spec change + if h.isNewRevision && comp.Spec.Helm != nil { if err = h.applyHelmModuleResources(ctx, comp, owners); err != nil { return errors.Wrap(err, "cannot apply Helm module resources") }