fix(health-check): derive status from previous_status_code instead of hardcoding False (#1354)

* fix(health-check): derive status from previous_status_code instead of hardcoding False

Signed-off-by: netram75 <netram.24bcs10329@sst.scaler.com>

* test(health-check): assert status field on change record in recovery test

Signed-off-by: netram75 <netram.24bcs10329@sst.scaler.com>

---------

Signed-off-by: netram75 <netram.24bcs10329@sst.scaler.com>
Co-authored-by: Paige Patton <64206430+paigerube14@users.noreply.github.com>

krkn/health_checks/http_health_check_plugin.py

@@ -210,7 +210,7 @@ class HttpHealthCheckPlugin(AbstractHealthCheckPlugin):
                         # Record the status change period
                         change_record = {
                             "url": url,
-                            "status": False,
+                            "status": previous_status_code == "200",
                             "status_code": previous_status_code,
                             "start_timestamp": start_timestamp.isoformat(),
                             "end_timestamp": end_timestamp.isoformat(),

tests/test_http_health_check_plugin.py

@@ -392,6 +392,8 @@ class TestHttpHealthCheckPlugin(unittest.TestCase):
         self.assertFalse(self.health_check_queue.empty())
         telemetry = self.health_check_queue.get()
         self.assertGreaterEqual(len(telemetry), 1)
+        change_entry = telemetry[0]
+        self.assertFalse(change_entry.status)
 
     @patch('krkn.health_checks.http_health_check_plugin.HttpHealthCheckPlugin.make_request')
     @patch('time.sleep')