From 92272f9143ca56c40e29d0e0a17667cfe6a5bd68 Mon Sep 17 00:00:00 2001 From: Netram Faran Date: Wed, 27 May 2026 22:25:28 +0530 Subject: [PATCH] fix(health-check): derive status from previous_status_code instead of hardcoding False (#1354) * fix(health-check): derive status from previous_status_code instead of hardcoding False Signed-off-by: netram75 * test(health-check): assert status field on change record in recovery test Signed-off-by: netram75 --------- Signed-off-by: netram75 Co-authored-by: Paige Patton <64206430+paigerube14@users.noreply.github.com> --- krkn/health_checks/http_health_check_plugin.py | 2 +- tests/test_http_health_check_plugin.py | 2 ++ 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/krkn/health_checks/http_health_check_plugin.py b/krkn/health_checks/http_health_check_plugin.py index d71e2f32..ecddf318 100644 --- a/krkn/health_checks/http_health_check_plugin.py +++ b/krkn/health_checks/http_health_check_plugin.py @@ -210,7 +210,7 @@ class HttpHealthCheckPlugin(AbstractHealthCheckPlugin): # Record the status change period change_record = { "url": url, - "status": False, + "status": previous_status_code == "200", "status_code": previous_status_code, "start_timestamp": start_timestamp.isoformat(), "end_timestamp": end_timestamp.isoformat(), diff --git a/tests/test_http_health_check_plugin.py b/tests/test_http_health_check_plugin.py index c75068c3..83103416 100644 --- a/tests/test_http_health_check_plugin.py +++ b/tests/test_http_health_check_plugin.py @@ -392,6 +392,8 @@ class TestHttpHealthCheckPlugin(unittest.TestCase): self.assertFalse(self.health_check_queue.empty()) telemetry = self.health_check_queue.get() self.assertGreaterEqual(len(telemetry), 1) + change_entry = telemetry[0] + self.assertFalse(change_entry.status) @patch('krkn.health_checks.http_health_check_plugin.HttpHealthCheckPlugin.make_request') @patch('time.sleep')