not return even if checkMetricProviderAvailability fails

pkg/controller/scheduler.go

@@ -119,7 +119,6 @@ func (c *Controller) advanceCanary(name string, namespace string) {
 	if !cd.SkipAnalysis() && (cd.Status.Phase == "" || cd.Status.Phase == flaggerv1.CanaryPhaseInitializing) {
 		if err := c.checkMetricProviderAvailability(cd); err != nil {
 			c.recordEventErrorf(cd, "Error checking metric providers: %v", err)
-			return
 		}
 	}
 

pkg/controller/scheduler_test.go

@@ -10,6 +10,7 @@ import (
 
 	flaggerv1 "github.com/weaveworks/flagger/pkg/apis/flagger/v1beta1"
 	clientset "github.com/weaveworks/flagger/pkg/client/clientset/versioned"
+
 	metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
 )