From a17e8b4794871a07a6448c7e69efa07c51ea89de Mon Sep 17 00:00:00 2001 From: mathetake Date: Fri, 15 May 2020 21:44:35 +0900 Subject: [PATCH] not return even if checkMetricProviderAvailability fails --- pkg/controller/scheduler.go | 1 - pkg/controller/scheduler_test.go | 1 + 2 files changed, 1 insertion(+), 1 deletion(-) diff --git a/pkg/controller/scheduler.go b/pkg/controller/scheduler.go index 565466ab..e636c07d 100644 --- a/pkg/controller/scheduler.go +++ b/pkg/controller/scheduler.go @@ -119,7 +119,6 @@ func (c *Controller) advanceCanary(name string, namespace string) { if !cd.SkipAnalysis() && (cd.Status.Phase == "" || cd.Status.Phase == flaggerv1.CanaryPhaseInitializing) { if err := c.checkMetricProviderAvailability(cd); err != nil { c.recordEventErrorf(cd, "Error checking metric providers: %v", err) - return } } diff --git a/pkg/controller/scheduler_test.go b/pkg/controller/scheduler_test.go index bf5a517c..1ad82dd8 100644 --- a/pkg/controller/scheduler_test.go +++ b/pkg/controller/scheduler_test.go @@ -10,6 +10,7 @@ import ( flaggerv1 "github.com/weaveworks/flagger/pkg/apis/flagger/v1beta1" clientset "github.com/weaveworks/flagger/pkg/client/clientset/versioned" + metav1 "k8s.io/apimachinery/pkg/apis/meta/v1" )