remove todo

This commit is contained in:
Yuval Kohavi
2019-04-23 07:42:52 -04:00
parent 4d7fae39a8
commit 5ba27c898e
+3 -6
View File
@@ -25,10 +25,9 @@ func TestSuperglooRouter_Sync(t *testing.T) {
if err := routingRuleClient.Register(); err != nil {
t.Fatal(err.Error())
}
// TODO(yuval-k): un hard code this
targetMesh := solokitcore.ResourceRef{
Namespace: "supergloo-system",
Name: "yuval",
Name: "mesh",
}
router := NewSuperglooRouterWithClient(context.TODO(), routingRuleClient, targetMesh, mocks.logger)
err = router.Reconcile(mocks.canary)
@@ -61,10 +60,9 @@ func TestSuperglooRouter_SetRoutes(t *testing.T) {
if err := routingRuleClient.Register(); err != nil {
t.Fatal(err.Error())
}
// TODO(yuval-k): un hard code this
targetMesh := solokitcore.ResourceRef{
Namespace: "supergloo-system",
Name: "yuval",
Name: "mesh",
}
router := NewSuperglooRouterWithClient(context.TODO(), routingRuleClient, targetMesh, mocks.logger)
@@ -126,10 +124,9 @@ func TestSuperglooRouter_GetRoutes(t *testing.T) {
if err := routingRuleClient.Register(); err != nil {
t.Fatal(err.Error())
}
// TODO(yuval-k): un hard code this
targetMesh := solokitcore.ResourceRef{
Namespace: "supergloo-system",
Name: "yuval",
Name: "mesh",
}
router := NewSuperglooRouterWithClient(context.TODO(), routingRuleClient, targetMesh, mocks.logger)
err = router.Reconcile(mocks.canary)