From 5ba27c898e4852f71be3e08563dc4660bea7e760 Mon Sep 17 00:00:00 2001 From: Yuval Kohavi Date: Tue, 23 Apr 2019 07:42:52 -0400 Subject: [PATCH] remove todo --- pkg/router/supergloo_test.go | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/pkg/router/supergloo_test.go b/pkg/router/supergloo_test.go index 2e31aa40..aa500b63 100644 --- a/pkg/router/supergloo_test.go +++ b/pkg/router/supergloo_test.go @@ -25,10 +25,9 @@ func TestSuperglooRouter_Sync(t *testing.T) { if err := routingRuleClient.Register(); err != nil { t.Fatal(err.Error()) } - // TODO(yuval-k): un hard code this targetMesh := solokitcore.ResourceRef{ Namespace: "supergloo-system", - Name: "yuval", + Name: "mesh", } router := NewSuperglooRouterWithClient(context.TODO(), routingRuleClient, targetMesh, mocks.logger) err = router.Reconcile(mocks.canary) @@ -61,10 +60,9 @@ func TestSuperglooRouter_SetRoutes(t *testing.T) { if err := routingRuleClient.Register(); err != nil { t.Fatal(err.Error()) } - // TODO(yuval-k): un hard code this targetMesh := solokitcore.ResourceRef{ Namespace: "supergloo-system", - Name: "yuval", + Name: "mesh", } router := NewSuperglooRouterWithClient(context.TODO(), routingRuleClient, targetMesh, mocks.logger) @@ -126,10 +124,9 @@ func TestSuperglooRouter_GetRoutes(t *testing.T) { if err := routingRuleClient.Register(); err != nil { t.Fatal(err.Error()) } - // TODO(yuval-k): un hard code this targetMesh := solokitcore.ResourceRef{ Namespace: "supergloo-system", - Name: "yuval", + Name: "mesh", } router := NewSuperglooRouterWithClient(context.TODO(), routingRuleClient, targetMesh, mocks.logger) err = router.Reconcile(mocks.canary)