github/woodpecker
1
0
Fork 0
mirror of https://github.com/woodpecker-ci/woodpecker.git synced 2026-02-13 21:00:00 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: allow spaces in WOODPECKER_PLUGINS_PRIVILEGED (#5494)

Browse Source
This commit is contained in:
Gusted
2025-09-10 00:33:53 +02:00
committed by GitHub
parent 3a0d225f3e
commit d2ea85e55f
14 changed files with 102 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
cli/admin/secret/secret_add.go
View File

@@ -41,10 +41,16 @@ var secretCreateCmd = &cli.Command{
&cli.StringSliceFlag{
Name: "event",
Usage: "secret limited to these events",
Config: cli.StringConfig{
TrimSpace: true,
},
},
&cli.StringSliceFlag{
Name: "image",
Usage: "secret limited to these images",
Config: cli.StringConfig{
TrimSpace: true,
},
},
},
}

6
cli/admin/secret/secret_set.go
View File

@@ -41,10 +41,16 @@ var secretUpdateCmd = &cli.Command{
&cli.StringSliceFlag{
Name: "event",
Usage: "secret limited to these events",
Config: cli.StringConfig{
TrimSpace: true,
},
},
&cli.StringSliceFlag{
Name: "image",
Usage: "secret limited to these images",
Config: cli.StringConfig{
TrimSpace: true,
},
},
},
}

15
cli/exec/flags.go
View File

@@ -47,16 +47,25 @@ var flags = []cli.Flag{
Sources: cli.EnvVars("WOODPECKER_VOLUMES"),
Name: "volumes",
Usage: "pipeline volumes",
Config: cli.StringConfig{
TrimSpace: true,
},
},
&cli.StringSliceFlag{
Sources: cli.EnvVars("WOODPECKER_NETWORKS"),
Name: "network",
Usage: "external networks",
Config: cli.StringConfig{
TrimSpace: true,
},
},
&cli.StringSliceFlag{
Sources: cli.EnvVars("WOODPECKER_PLUGINS_PRIVILEGED"),
Name: "plugins-privileged",
Usage: "Allow plugins to run in privileged mode, if environment variable is defined but empty there will be none",
Config: cli.StringConfig{
TrimSpace: true,
},
},
&cli.StringFlag{
Sources: cli.EnvVars("WOODPECKER_BACKEND"),
@@ -289,6 +298,9 @@ var flags = []cli.Flag{
Sources: cli.EnvVars("CI_COMMIT_PULL_REQUEST_LABELS"),
Name: "commit-pull-labels",
Usage: "Set the metadata environment variable \"CI_COMMIT_PULL_REQUEST_LABELS\".",
Config: cli.StringConfig{
TrimSpace: true,
},
},
&cli.StringFlag{
Sources: cli.EnvVars("CI_COMMIT_PULL_REQUEST_MILESTONE"),
@@ -399,6 +411,9 @@ var flags = []cli.Flag{
Sources: cli.EnvVars("CI_ENV"),
Name: "env",
Usage: "Set the metadata environment variable \"CI_ENV\".",
Config: cli.StringConfig{
TrimSpace: true,
},
},
&cli.StringFlag{
Sources: cli.EnvVars("CI_FORGE_TYPE"),

6
cli/lint/lint.go
View File

@@ -41,12 +41,18 @@ var Command = &cli.Command{
Sources: cli.EnvVars("WOODPECKER_PLUGINS_PRIVILEGED"),
Name: "plugins-privileged",
Usage: "allow plugins to run in privileged mode, if set empty, there is no",
Config: cli.StringConfig{
TrimSpace: true,
},
},
&cli.StringSliceFlag{
Sources: cli.EnvVars("WOODPECKER_PLUGINS_TRUSTED_CLONE"),
Name: "plugins-trusted-clone",
Usage: "plugins that are trusted to handle Git credentials in cloning steps",
Value: constant.TrustedClonePlugins,
Config: cli.StringConfig{
TrimSpace: true,
},
},
&cli.BoolFlag{
Sources: cli.EnvVars("WOODPECKER_LINT_STRICT"),

6
cli/org/secret/secret_add.go
View File

@@ -44,10 +44,16 @@ var secretCreateCmd = &cli.Command{
&cli.StringSliceFlag{
Name: "event",
Usage: "secret limited to these events",
Config: cli.StringConfig{
TrimSpace: true,
},
},
&cli.StringSliceFlag{
Name: "image",
Usage: "secret limited to these images",
Config: cli.StringConfig{
TrimSpace: true,
},
},
},
}

6
cli/org/secret/secret_set.go
View File

@@ -44,10 +44,16 @@ var secretUpdateCmd = &cli.Command{
&cli.StringSliceFlag{
Name: "event",
Usage: "limit secret to these event",
Config: cli.StringConfig{
TrimSpace: true,
},
},
&cli.StringSliceFlag{
Name: "image",
Usage: "limit secret to these image",
Config: cli.StringConfig{
TrimSpace: true,
},
},
},
}

3
cli/pipeline/create.go
View File

@@ -39,6 +39,9 @@ var pipelineCreateCmd = &cli.Command{
&cli.StringSliceFlag{
Name: "var",
Usage: "key=value",
Config: cli.StringConfig{
TrimSpace: true,
},
},
}...),
}

3
cli/pipeline/deploy/deploy.go
View File

@@ -54,6 +54,9 @@ var Command = &cli.Command{
Name: "param",
Aliases: []string{"p"},
Usage: "custom parameters to inject into the step environment. Format: KEY=value",
Config: cli.StringConfig{
TrimSpace: true,
},
},
},
}

3
cli/pipeline/start.go
View File

@@ -36,6 +36,9 @@ var pipelineStartCmd = &cli.Command{
Name: "param",
Aliases: []string{"p"},
Usage: "custom parameters to inject into the step environment. Format: KEY=value",
Config: cli.StringConfig{
TrimSpace: true,
},
},
},
}

6
cli/repo/secret/secret_add.go
View File

@@ -44,10 +44,16 @@ var secretCreateCmd = &cli.Command{
&cli.StringSliceFlag{
Name: "event",
Usage: "limit secret to these events",
Config: cli.StringConfig{
TrimSpace: true,
},
},
&cli.StringSliceFlag{
Name: "image",
Usage: "limit secret to these images",
Config: cli.StringConfig{
TrimSpace: true,
},
},
},
}

6
cli/repo/secret/secret_set.go
View File

@@ -44,10 +44,16 @@ var secretUpdateCmd = &cli.Command{
&cli.StringSliceFlag{
Name: "event",
Usage: "limit secret to these events",
Config: cli.StringConfig{
TrimSpace: true,
},
},
&cli.StringSliceFlag{
Name: "image",
Usage: "limit secret to these images",
Config: cli.StringConfig{
TrimSpace: true,
},
},
},
}

3
cmd/agent/core/flags.go
View File

@@ -67,6 +67,9 @@ var flags = []cli.Flag{
Name: "labels",
Aliases: []string{"filter"}, // remove in v4.x
Usage: "List of labels to filter tasks on. An agent must be assigned every tag listed in a task to be selected.",
Config: cli.StringConfig{
TrimSpace: true,
},
},
&cli.IntFlag{
Sources: cli.EnvVars("WOODPECKER_MAX_WORKFLOWS", "WOODPECKER_MAX_PROCS"), // cspell:words PROCS

30
cmd/server/flags.go
View File

@@ -126,16 +126,25 @@ var flags = append([]cli.Flag{
Sources: cli.EnvVars("WOODPECKER_ADMIN"),
Name: "admin",
Usage: "list of admin users",
Config: cli.StringConfig{
TrimSpace: true,
},
},
&cli.StringSliceFlag{
Sources: cli.EnvVars("WOODPECKER_ORGS"),
Name: "orgs",
Usage: "list of approved organizations",
Config: cli.StringConfig{
TrimSpace: true,
},
},
&cli.StringSliceFlag{
Sources: cli.EnvVars("WOODPECKER_REPO_OWNERS"),
Name: "repo-owners",
Usage: "Repositories by those owners will be allowed to be used in woodpecker",
Config: cli.StringConfig{
TrimSpace: true,
},
},
&cli.BoolFlag{
Sources: cli.EnvVars("WOODPECKER_OPEN"),
@@ -164,6 +173,9 @@ var flags = append([]cli.Flag{
Name: "default-cancel-previous-pipeline-events",
Usage: "List of event names that will be canceled when a new pipeline for the same context (tag, branch) is created.",
Value: []string{"push", "pull_request"},
Config: cli.StringConfig{
TrimSpace: true,
},
},
&cli.StringFlag{
Sources: cli.EnvVars("WOODPECKER_DEFAULT_CLONE_PLUGIN", "WOODPECKER_DEFAULT_CLONE_IMAGE"),
@@ -188,6 +200,9 @@ var flags = append([]cli.Flag{
Sources: cli.EnvVars("WOODPECKER_DEFAULT_WORKFLOW_LABELS"),
Name: "default-workflow-labels",
Usage: "The default label filter to set for workflows that has no label filter set. By default workflows will be allowed to run on any agent, if not specified in the workflow.",
Config: cli.StringConfig{
TrimSpace: true,
},
},
&cli.DurationFlag{
Sources: cli.EnvVars("WOODPECKER_SESSION_EXPIRES"),
@@ -199,16 +214,25 @@ var flags = append([]cli.Flag{
Sources: cli.EnvVars("WOODPECKER_PLUGINS_PRIVILEGED"),
Name: "plugins-privileged",
Usage: "Allow plugins to run in privileged mode, if environment variable is defined but empty there will be none",
Config: cli.StringConfig{
TrimSpace: true,
},
},
&cli.StringSliceFlag{
Sources: cli.EnvVars("WOODPECKER_PLUGINS_TRUSTED_CLONE"),
Name: "plugins-trusted-clone",
Usage: "Plugins which are trusted to handle Git credentials in clone steps",
Value: constant.TrustedClonePlugins,
Config: cli.StringConfig{
TrimSpace: true,
},
},
&cli.StringSliceFlag{
Sources: cli.EnvVars("WOODPECKER_VOLUME"),
Name: "volume",
Config: cli.StringConfig{
TrimSpace: true,
},
},
&cli.StringFlag{
Sources: cli.EnvVars("WOODPECKER_DOCKER_CONFIG"),
@@ -217,10 +241,16 @@ var flags = append([]cli.Flag{
&cli.StringSliceFlag{
Sources: cli.EnvVars("WOODPECKER_ENVIRONMENT"),
Name: "environment",
Config: cli.StringConfig{
TrimSpace: true,
},
},
&cli.StringSliceFlag{
Sources: cli.EnvVars("WOODPECKER_NETWORK"),
Name: "network",
Config: cli.StringConfig{
TrimSpace: true,
},
},
&cli.StringFlag{
Sources: cli.NewValueSourceChain(

3
pipeline/backend/kubernetes/flags.go
View File

@@ -100,6 +100,9 @@ var Flags = []cli.Flag{
Sources: cli.EnvVars("WOODPECKER_BACKEND_K8S_PULL_SECRET_NAMES"),
Name: "backend-k8s-pod-image-pull-secret-names",
Usage: "backend k8s pull secret names for private registries",
Config: cli.StringConfig{
TrimSpace: true,
},
},
&cli.BoolFlag{
Sources: cli.EnvVars("WOODPECKER_BACKEND_K8S_ALLOW_NATIVE_SECRETS"),