github/wonderwall
1
0
Fork 0
mirror of https://github.com/nais/wonderwall.git synced 2026-05-10 18:37:00 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(url/redirect): fallback url must be absolute

Browse Source
This commit is contained in:
Trong Huu Nguyen
2023-07-13 12:43:24 +02:00
parent c44fb9889b
commit cf3a445656
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
pkg/url/redirect.go
View File

@@ -61,7 +61,7 @@ type SSOServerRedirect struct {
}
func NewSSOServerRedirect(config *config.Config) (*SSOServerRedirect, error) {
u, err := url.Parse(config.SSO.ServerDefaultRedirectURL)
u, err := url.ParseRequestURI(config.SSO.ServerDefaultRedirectURL)
if err != nil {
return nil, fmt.Errorf("parsing fallback redirect URL: %w", err)
}
@@ -113,7 +113,7 @@ func (h *SSOProxyRedirect) Canonical(r *http.Request) string {
if err != nil {
logInvalidRedirect(r, target, redirect.String())
} else {
// preserve path, query and fragment from redirect parameter to base redirect
// copy and preserve relevant parts from parsed redirect parameter to base redirect
redirect.Path = redirectParamURL.Path
redirect.RawQuery = redirectParamURL.RawQuery
redirect.Fragment = redirectParamURL.Fragment