refactor(otel): move logrus hook to otel

Co-authored-by: sindrerh2 <sindre.rodseth.hansen@nav.no>
This commit is contained in:
Trong Huu Nguyen
2025-01-28 14:54:19 +01:00
parent ca77435d6a
commit bd2ec2dcf2
2 changed files with 12 additions and 11 deletions

View File

@@ -5,7 +5,6 @@ import (
"time"
log "github.com/sirupsen/logrus"
"github.com/uptrace/opentelemetry-go-extra/otellogrus"
)
func textFormatter() log.Formatter {
@@ -40,15 +39,5 @@ func SetupLogger(level, format string) error {
log.SetLevel(logLevel)
log.Tracef("Trace logging enabled")
// Add OpenTelemetry logging hook.
// This attaches logs to the associated span in the given log context as events.
log.AddHook(otellogrus.NewHook(otellogrus.WithLevels(
log.PanicLevel,
log.FatalLevel,
log.ErrorLevel,
log.WarnLevel,
log.InfoLevel,
)))
return nil
}

View File

@@ -5,6 +5,7 @@ import (
"time"
log "github.com/sirupsen/logrus"
"github.com/uptrace/opentelemetry-go-extra/otellogrus"
"go.opentelemetry.io/otel/trace/noop"
"go.opentelemetry.io/otel"
@@ -47,6 +48,17 @@ func SetupOpenTelemetry(ctx context.Context, serviceName, version string) (func(
shutdown := func(ctx context.Context) error {
return tracerProvider.Shutdown(ctx)
}
// Add OpenTelemetry logging hook to logrus.
// This attaches logs to the associated span in the given log context as events.
log.AddHook(otellogrus.NewHook(otellogrus.WithLevels(
log.PanicLevel,
log.FatalLevel,
log.ErrorLevel,
log.WarnLevel,
log.InfoLevel,
)))
return shutdown, nil
}