github/wonderwall
1
0
Fork 0
mirror of https://github.com/nais/wonderwall.git synced 2026-05-21 07:42:53 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: add server timeouts to prevent goroutine/memory leak from idle keep-alive connections

Browse Source 
Without IdleTimeout, clients holding keep-alive connections open indefinitely
caused server-side goroutines (and their ~16KB of buffers) to accumulate
linearly until OOM.
This commit is contained in:
Trong Huu Nguyen
2026-05-07 16:00:14 +02:00
parent a8f930e276
commit 1939d18ba8
1 changed files with 6 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
pkg/server/server.go
View File

@@ -17,8 +17,12 @@ import (
func Start(cfg *config.Config, r chi.Router) error {
server := http.Server{
Addr: cfg.BindAddress,
Handler: r,
Addr: cfg.BindAddress,
Handler: r,
ReadHeaderTimeout: 10 * time.Second, // Prevents slowloris attacks (connections held open without sending headers).
IdleTimeout: 90 * time.Second, // Reclaims idle keep-alive connections; without this, goroutines and buffers leak indefinitely.
MaxHeaderBytes: 1 << 16, // 64KB
// ReadTimeout/WriteTimeout intentionally omitted - a reverse proxy must support slow transfers.
}
serverCtx, serverStopCtx := context.WithCancel(context.Background())