github/wonderwall
1
0
Fork 0
mirror of https://github.com/nais/wonderwall.git synced 2026-05-06 00:17:27 +00:00
Code Issues Packages Projects Releases Wiki Activity

test(openid/client): add negative assertions for unwanted parameters

Browse Source
This commit is contained in:
Trong Huu Nguyen
2025-01-24 08:07:11 +01:00
parent fc715e703b
commit 0b32d8839c
2 changed files with 12 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
pkg/mock/openid.go
View File

@@ -64,6 +64,10 @@ func (in *IdentityProvider) GetRequest(target string) *http.Request {
return NewGetRequest(target, in.RelyingPartyHandler.GetIngresses())
}
func (in *IdentityProvider) WithPushedAuthorizationRequestEndpoint() {
in.OpenIDConfig.TestProvider.SetPushedAuthorizationRequestEndpoint(in.ProviderServer.URL + "/par")
}
func NewIdentityProvider(cfg *config.Config) *IdentityProvider {
rpServer := newRelyingPartyServer()
cfg.Ingresses = append(cfg.Ingresses, rpServer.GetURL())

11
pkg/openid/client/login_test.go
View File

@@ -14,13 +14,13 @@ import (
urlpkg "github.com/nais/wonderwall/pkg/url"
)
func TestLogin_PushAuthorizationURL(t *testing.T) {
func TestLogin_PushedAuthorizationRequest(t *testing.T) {
cfg := mock.Config()
idp := mock.NewIdentityProvider(cfg)
idp.OpenIDConfig.TestProvider.SetPushedAuthorizationRequestEndpoint(idp.ProviderServer.URL + "/par")
idp.WithPushedAuthorizationRequestEndpoint()
defer idp.Close()
req := idp.GetRequest(mock.Ingress + "/oauth2/login")
req := idp.GetRequest(mock.Ingress + "/oauth2/login")
result, err := idp.RelyingPartyHandler.Client.Login(req)
require.NoError(t, err)
@@ -30,6 +30,7 @@ func TestLogin_PushAuthorizationURL(t *testing.T) {
query := parsed.Query()
assert.Contains(t, query, "request_uri")
assert.Contains(t, query, "client_id")
assert.Len(t, query, 2)
assert.NotEmpty(t, query["request_uri"])
assert.Contains(t, query["request_uri"][0], "urn:ietf:params:oauth:request_uri")
@@ -146,7 +147,11 @@ func TestLogin_URL(t *testing.T) {
assert.Contains(t, query, "response_mode")
assert.Contains(t, query, "code_challenge")
assert.Contains(t, query, "code_challenge_method")
assert.NotContains(t, query, "resource")
assert.NotContains(t, query, "client_secret")
assert.NotContains(t, query, "client_assertion")
assert.NotContains(t, query, "client_assertion_type")
callbackURL, err := urlpkg.LoginCallback(req)
assert.NoError(t, err)