Commit Graph

2349 Commits

Author SHA1 Message Date
Jonathan Lange
49f2e4e40c Count memcache requests even if they time out 2016-07-11 13:01:02 +01:00
Alfonso Acosta
9a77380a59 Merge pull request #1653 from weaveworks/1598-no-host-short-lived-tracking
Do not infer short-lived connections for host-networking containers
2016-07-07 17:53:08 +01:00
Alfonso Acosta
26c6249516 Review comments 2016-07-07 16:18:18 +00:00
Alfonso Acosta
c843d24f6f Do not infer short-lived connections for host-networking containers 2016-07-07 15:44:13 +00:00
Jonathan Lange
17dc928b07 Merge pull request #1646 from weaveworks/experimental-results
Promote fixprobe and delete rest of experimental
2016-07-07 16:43:35 +01:00
Jonathan Lange
7cc829e463 What's tracer? 2016-07-07 15:02:26 +01:00
Jonathan Lange
1c440486f0 Delete experimental, replace with 'extras'
extras contains fixprobe and example, and ought to build properly
2016-07-07 14:30:08 +01:00
Alfonso Acosta
6d527821e7 Merge pull request #1627 from weaveworks/1605-read-only
Allow disabling controls in probes
2016-07-07 13:37:04 +01:00
Alfonso Acosta
5bb6185515 Clarify no-controls flag 2016-07-07 12:36:33 +00:00
Justin Garrison
d65a656e8f quote jsonpath so shell doesn't try to expand (#1651) 2016-07-06 20:56:19 +01:00
Paul Bellamy
b89e9ec891 Merge pull request #1641 from weaveworks/fix-column-widths
Force some known column widths to prevent truncation of others
2016-07-05 14:39:18 +01:00
Paul Bellamy
8cb1ecdf2c Merge pull request #1642 from weaveworks/refactoring-timing
refactor some timing helpers into a common lib
2016-07-05 13:01:28 +01:00
Paul Bellamy
7736564337 refactor some timing helpers into a common lib 2016-07-05 12:29:00 +01:00
Alfonso Acosta
6175880725 Review feedback 2016-07-05 10:47:57 +00:00
Simon Howe
f11c559499 Force some known column widths to prevent truncation of others
Port/count won't exceed a certain width so slim those down to free up
space for the IPs.

This can be extended to CPU/memory in the future but that needs a little
more refactoring in the number renderers
2016-07-05 12:26:10 +02:00
Alfonso Acosta
74e508671c Merge pull request #1606 from weaveworks/1594-no-sudo-for-launch
Don't prepend `scope launch` with sudo
2016-07-05 11:13:38 +01:00
Alfonso Acosta
7b3862f05b Review feedback 2016-07-05 10:09:40 +00:00
Alfonso Acosta
59ec3b863a Review comments 2016-07-04 17:22:58 +00:00
Alfonso Acosta
5d23432a6c Check write access to unix socket 2016-07-04 17:08:49 +00:00
Jonathan Lange
d79a412116 Merge pull request #1640 from weaveworks/bump-timeout
Bump memcache expiration
2016-07-04 16:54:59 +01:00
Jonathan Lange
45d0e5441a Change default timeout for things in the memcache 2016-07-04 16:04:04 +01:00
Jonathan Lange
31c88fd62b Instrumentation that we might like to keep 2016-07-04 16:03:50 +01:00
Alfonso Acosta
c0d5c394ad Fix demoprobe 2016-07-04 14:32:07 +00:00
Jonathan Lange
848574eced Make expiration a flag 2016-07-04 14:20:14 +01:00
Jonathan Lange
7dd2c6371e Parametrize window rather than assuming default 2016-07-04 13:50:54 +01:00
Jonathan Lange
c1dab17fb3 Make expiration a Duration 2016-07-04 13:30:23 +01:00
Jonathan Lange
f7bdedc149 Config struct for memcache client 2016-07-04 13:25:45 +01:00
Jonathan Lange
96520d7a46 Fixes to memcache support (#1628)
* Fix errors discovered in dev

* Log an error rather than aborting when memcache doesn't resolve
* Initialize map correctly

* Review tweaks
2016-07-04 11:00:11 +01:00
Alfonso Acosta
205ee5b4e6 Fix fixprobe 2016-07-01 17:30:10 +00:00
Alfonso Acosta
c0a672c02a Review feedback 2016-07-01 16:51:57 +00:00
Alfonso Acosta
6f1e52cd0d Allow disabling controls in probes 2016-07-01 15:06:06 +00:00
Jonathan Lange
682edd37e4 Merge pull request #1616 from weaveworks/debug-instrument-memcache
Refactor caching layers in AWS collector
2016-06-30 18:10:32 +01:00
Jonathan Lange
9e0f0c51b9 Configuration type for AWS collector 2016-06-30 17:01:58 +01:00
Jonathan Lange
baacaa8cc5 Rename dynamoCollector to awsCollector 2016-06-30 16:44:43 +01:00
Jonathan Lange
6520f8f5f3 Pass in memcache client 2016-06-30 09:59:55 +01:00
Jonathan Lange
abec257c59 Just pass in the s3 client 2016-06-30 09:57:49 +01:00
Jonathan Lange
d984605de1 Write back to the in-process cache 2016-06-30 09:57:49 +01:00
Jonathan Lange
5ec422c7a3 Fetch all reports at once
Rather than have getReports be responsible for determining keys, instead
call getReportKeys directly and then pass keys to getReports
2016-06-30 09:57:49 +01:00
Jonathan Lange
87da22767e Move s3 logic to separate file 2016-06-30 09:57:49 +01:00
Jonathan Lange
e2bda8f670 Move last memcache bits out of dynamo_collector 2016-06-30 09:55:03 +01:00
Julius Volz
4fa40e22b2 Rework Scope metrics according to Prometheus conventions. (#1615)
* Rework Scope metrics according to Prometheus conventions.

- counters should end with _total
- elaborated and added units to help strings
- recommended for cache hit/miss metrics: track only the total and the
  hits and in separate metrics, since the most common query will be
  "hits / total"
- track all times in seconds (base units), which has become the standard
  recommendation
- other small changes

There could be more changes that would require more thinking (what
dimensions to use, summaries vs. histograms, etc.), but this is probably
enough controversial material already :)

* Use timeRequestStatus() in sqs_control_router.go.
2016-06-30 09:12:25 +01:00
Alfonso Acosta
05e6193e63 Merge pull request #1607 from weaveworks/1577-print-dns-errors
Print DNS errors
2016-06-28 01:58:54 +02:00
Alfonso Acosta
d33358ec63 Review feedback 2016-06-27 16:59:42 +00:00
Tom Wilkie
ab3d34be01 Make it easier to disable weave integrations (#1610)
* Make it easier to disable weave integrations

* Review feedback

* Make test pass
2016-06-27 16:11:57 +01:00
Tom Wilkie
1b32cc94c7 Clarify instructions for using Scope with Weave Cloud (#1611)
* Clarify instructions for using Scope with Weave Cloud

* Some more references to scope.w.w

* a few tweaks to tenses and punctuation
2016-06-27 10:15:03 +01:00
Tom Wilkie
8e1a6b3667 Add dry run flag to scope, so when launched we can check the args are valid. (#1609)
* Add dry run flag to scope, so when launched we can check the args are valid.

* Try and parse listen address and error early.

* Specify that -dry-run is for internal use only.
2016-06-27 10:13:55 +01:00
Jonathan Lange
d99a0162c6 Merge pull request #1612 from weaveworks/fix-memcache-crash
Fix nil pointer error when memcache not enabled
2016-06-26 14:37:38 +01:00
Jonathan Lange
387c543a87 Fix nil pointer error when memcache not enabled 2016-06-24 14:01:46 +01:00
Tom Wilkie
29133e54ca Add backoff to the consul client (#1608)
* Add backoff to the consul client

* Review feedback
2016-06-24 09:04:08 +01:00
Alfonso Acosta
cab948887d Print DNS errors 2016-06-23 10:44:43 +00:00