github/weave-scope
1
0
Fork 0
mirror of https://github.com/weaveworks/scope.git synced 2026-09-06 10:17:19 +00:00
Code Issues Packages Projects Releases Wiki Activity
3,140 Commits 85 Branches 64 Tags
3a69c19d6e41e5474f31bf0ccc31b1f76a9b5641
Commit Graph
3140 Commits
This Branch
This Branch
All Branches
Author SHA1 Message Date
Mike Lang 3a69c19d6e scope launch script: Also recongize -h, -help and --help 2016-12-12 11:26:01 -08:00
Mike Lang 90709b61aa scope launch script: Fix and consolidate usage info 
Instead of different usage info for "scope help", show the same always.
Also correct it for what the script actually does,
and always display the scope binary args.
 2016-12-12 11:26:01 -08:00
Mike Lang b1a1c7d427 scope launch script: Attempt to quote args in "scope command" 
As indicated by the TODO, any args passed into the command do not get escaped
when output, so for example:
	scope command "foo bar"
would output results like:
	foo bar
instead of
	"foo bar"
or
	foo\ bar

The "right" way to do this seems to be printf %q, which prints a quoted version of the string.
However this format specifier is not available in POSIX sh (though it does work in many
implementations of it, such as the ones provided by bash which make up the likely majority of
real-world usage).
This code is a compromise that uses the added functionality where available,
while still falling back to the old behaviour when it isn't.
 2016-12-12 11:26:00 -08:00
Mike Lang 21431bb4b0 scope launch script: Fix shellcheck linter warnings 
By far the majority of these were variables which were not quoted.
While, yes, right now we can guarentee most of these variables will never contain spaces,
this could someday change and applying quoting as a universal rule prevents future mistakes.

The ARGS="$@" -> "$*" change is purely stylistic and mainly is used to indicate the intent that
we actually wanted to concatenate all the args by spaces, not keep them seperated as "$@" would
in many situations, but not this one.

Several warnings remain, in places where we intentionally want to split a variable on whitespace,
or otherwise do what shellcheck is warning us against.

Of note is shellcheck warning SC2166, which says to prefer [ foo ] || [ bar ] over [ foo -o bar ]
as the -a and -o flags have differing behaviour on some systems.
I've opted to keep these for now, since the version check test command would need to be replaced by
a LOT of subshells to achieve the same effect, which feels dirtier.
 2016-12-12 11:26:00 -08:00
jpellizzari 70960cc67a Fixed client linting errors 2016-12-09 10:11:58 -08:00
Jordan Pellizzari b5a720e17c Merge pull request #2076 from weaveworks/2075-client-linting 
Add client linting to CI config
 2016-12-09 08:04:01 -08:00
Filip Barl 244bba2d26 Merge pull request #2053 from weaveworks/lodash-partial-imports 
Importing lodash util functions explicitly
 2016-12-09 14:36:33 +01:00
Filip Barl 4142474e46 Added babel-plugin-lodash library for automatic cherry-picking of the Lodash modules 2016-12-09 14:07:22 +01:00
fbarl 524e2e2e9a Importing lodash util functions explicitly. 2016-12-09 14:03:31 +01:00
Jordan Pellizzari 856a5a0388 Merge pull request #2071 from weaveworks/2056-graph-table-buttons 
Fix grid-mode-selector styling
 2016-12-08 14:47:10 -08:00
jpellizzari 7fba78c7b3 Liniting fixes 2016-12-08 11:08:48 -08:00
jpellizzari 38344a2a48 Added client linting to circle.yml 2016-12-08 11:08:25 -08:00
Jonathan Lange e387f8c5d8 Merge pull request #2074 from weaveworks/correct-ws-handshake 
Correctly instrument websocket handshakes
 2016-12-08 18:01:35 +00:00
Jonathan Lange 813e6468bc Correctly instrument websocket handshakes 
Part of weaveworks/monitoring#82
 2016-12-08 17:36:45 +00:00
David Kaltschmidt 5687054126 Allow relative paths for assets in local webpack config 2016-12-08 16:30:07 +01:00
jpellizzari 431be4cf25 Fixed grid-mode-selector styling 2016-12-07 16:32:19 -08:00
Peter Bourgon 90c29f249d Merge pull request #2067 from weaveworks/k8s-curl-redirections 
Follow redirections in curl when getting k8s resources
 2016-12-07 17:08:48 +01:00
Alfonso Acosta 78dd2f0c76 Follow redirections in curl when getting k8s resources 2016-12-07 16:35:55 +01:00
Alfonso Acosta 07aee0ed97 Merge pull request #2020 from kinvolk/alban/fix-getWalkedProcPid 
procspy: use a Reader to copy the background reader buffer
 2016-12-07 12:53:53 +01:00
Jonathan Lange 9a92961a5f Merge pull request #2061 from weaveworks/use-common-lib 
Use newly-created 'common' repo
 2016-12-07 11:51:35 +00:00
Jonathan Lange 1020fc5f85 Use test.Diff from common 2016-12-07 11:22:40 +00:00
Jonathan Lange 496afb9a42 Vendor in weaveworks/common 2016-12-07 11:22:39 +00:00
Jonathan Lange b5c750ddea Move test & fs 2016-12-07 11:22:39 +00:00
Jonathan Lange e8085b01b6 Use 'common' library 2016-12-07 11:22:38 +00:00
fbarl 6344358c6b Fix all the npm library versions (resolve #2052) 2016-12-07 11:22:38 +00:00
Alban Crequy 543f3d5bdc procspy: use a Reader to copy the background reader buffer 
getWalkedProcPid() reads latestBuf every 3 seconds (for each report).
But performWalk() writes latestBuf every 10 seconds or so. So we need to
be able to read the same buffer several times.
 2016-12-05 18:12:11 +01:00
Filip Barl 9d5d431a59 Merge pull request #2057 from weaveworks/fix-npm-versions 
Fix all the npm library versions
 2016-12-05 16:15:35 +01:00
Alfonso Acosta b4d5665fd8 Merge pull request #2021 from kinvolk/alban/linter 
linter: fix punctuation and capitalization
 2016-12-05 15:45:01 +01:00
fbarl 1bc27ee40f Fix all the npm library versions (resolve #2052) 2016-12-05 14:57:25 +01:00
David 4fe3efc364 Merge pull request #2045 from weaveworks/remove-waypoints-cap-on-edge-containers 
Remove upper bound for waypoints count on edges
 2016-12-05 11:57:31 +01:00
David 5ae3a5aba2 Merge pull request #2034 from weaveworks/use-webpack-dev-middleware 
Using `webpack-dev-middleware` instead of `webpack-dev-server` directly
 2016-12-05 11:52:44 +01:00
David Kaltschmidt 1bfdfc84f6 Using eval-source-maps in webpack for now 
keep original code, quite fast on rebuilds
 2016-12-05 11:52:23 +01:00
David Kaltschmidt 298f27bf3f Remove polling for webpack (was CPU heavy) and HMR for vendors 2016-12-05 11:30:06 +01:00
fbarl e8eba61c37 Remove the dagre waypoints limitation for edges and replace it with WAYPOINTS_CAP constant for fine tunning (fix #1187) 2016-12-02 17:00:46 +01:00
Filip Barl 92a02fb587 Merge pull request #2048 from weaveworks/d4-hotfixes 
Fix two bugs caused by transition to D3 v4
 2016-11-30 12:23:31 +01:00
Simon Howe f50e0bf72f Fixes container and pod metric fill direction back to vertical 
Was flipped to horizontal for a bit there as we transitioned from d3 v3->v4
 2016-11-30 11:32:16 +01:00
fbarl 52136cd8b5 Replaced rangeBands with scaleBand().range 2016-11-30 11:15:40 +01:00
Alfonso Acosta 0ad3224485 Merge pull request #2046 from weaveworks/update-scope-version-in-docs 
Update Scope version in install docs
 2016-11-29 11:05:35 -08:00
Alfonso Acosta cc32864ce1 Update Scope version in install docs 2016-11-29 19:04:55 +00:00
Alfonso Acosta 03f0ef64a7 Merge pull request #2033 from weaveworks/release-1.1 
Release 1.1.0
 2016-11-29 11:00:20 -08:00
Alfonso Acosta 064823c1d9 Update CHANGELOG v1.1.0 2016-11-29 16:21:28 +00:00
Alfonso Acosta 2fc80369e6 Update CHANGELOG 2016-11-29 16:19:38 +00:00
Alfonso Acosta d47ae4bf80 Release 1.1.0 2016-11-29 16:19:37 +00:00
David 8d8c106471 Merge pull request #2043 from weaveworks/2037-fix-asset-path 
Empty publicpath needed for relative paths of scope
 2016-11-29 17:01:30 +01:00
David Kaltschmidt 03b34448e2 Empty publicpath needed for relative paths of scope 
Fixes #2037
 2016-11-29 16:56:03 +01:00
Alfonso Acosta aaf2b0a815 Merge pull request #2026 from weaveworks/mike/ecs/initial 
Add ECS views
 2016-11-29 07:42:59 -08:00
Mike Lang d0caee4748 Add some basic metadata to the ECS task/service details panels 2016-11-29 07:18:08 -08:00
Alfonso Acosta 9c7282231f Fix tests 
Also, refactor some tests and MakeRegistry in api_topologies
 2016-11-29 07:18:08 -08:00
Mike Lang 003ef6b4ea Add some basic metadata to ECS nodes 2016-11-29 07:18:08 -08:00
Mike Lang 9a10e9650d Fix the one instance of "make" that is actually apparently required 2016-11-29 07:18:08 -08:00