2941 Commits
Author SHA1 Message Date
Simon Howe aaee43a76b Make the port column a little wider to stop truncation
- Set kubernetes_ip width too to stop truncation
2016-08-04 14:03:41 +02:00
Krzesimir Nowak 97eb8d033d Do not spell check Makefiles and JSON files
Spell check does not handle JSON files very well. It finds misspelled
words in hexadecimal hashes (like misspelled "dead" in "123daed456").

Ignore Makefiles too - there is not so much free text to spell check
and the spell check complains about words it was told by Makefile to
ignore.
2016-08-04 12:02:39 +02:00
Krzesimir Nowak dcaa7503b8 Fix a typo
The typo is here from March, 2016. It is strange that it wasn't
detected earlier.
2016-08-04 11:36:04 +02:00
SimonandGitHub 8ce5bdb00d Merge pull request #1747 from weaveworks/sort-nodes-nicely-1744
table-mode: handle nodes w/ no value for sorted column gracefully
2016-08-03 17:47:48 +02:00
Simon Howe d02cb25495 Tidyup JS: make keys in grouping dict more sensible
true/false are confusing.
2016-08-03 17:25:09 +02:00
Paul BellamyandGitHub 2bba18dbfa Merge pull request #1710 from kinvolk/alban/hub2
circle.yml: another fix for deploy master with non-upstream hub accounts
2016-08-03 13:48:59 +01:00
Simon Howe 6c0f8ba638 table-mode: handle nodes w/ no value for sorted column gracefully
- put empty values below those that have a value.

+-----+-----+
|3    |5    |
|4    |4    |
|5    |3    |
|null |null |
|null |null |
+-----+-----+
2016-08-03 14:21:33 +02:00
SimonandGitHub 5a872da0cf Merge pull request #1673 from weaveworks/grid-view
Grid Mode
2016-08-03 09:48:23 +02:00
Simon Howe 504eb7f6e3 Fixes after rebasing onto master (loading-indicator) 2016-08-03 09:11:17 +02:00
Simon Howe 925905bc43 Table-mode: fixes processes view if internet is present.
- Also adds tooltip for id label column (container/process name)
2016-08-03 08:53:07 +02:00
Simon Howe 3e4ec1dc61 Review feedback + fiddling w/ the columns widths a little more. 2016-08-03 08:53:07 +02:00
Simon Howe a2810afaf1 Fixes grid -> topo transition.
- Also don't show table borders when no nodes.
- 't' toggles table mode on/off, rather than 't'/v'
2016-08-03 08:51:07 +02:00
Simon Howe df1efff19b Force a layout after a toggle to viz-mode 2016-08-03 08:51:06 +02:00
Simon Howe f83e0f1a48 Remove a lot of un-used code that I still want to keep 2016-08-03 08:51:06 +02:00
Simon Howe 29e67683b3 New selection model.
- highlight whole row
- don't do anything when selecting text
2016-08-03 08:50:37 +02:00
Simon Howe d0b99969ea Grid-mode tuning!
- Change scrolling behaviour to lock headers in place
- Enable filtering (hitting enter in the search bar) in grid-mode
- Little more top-margin for k8s (can have 3 topos) + taller rows.
- Trying out rank-color + node.relatives in the grid-mode
- First pass at selecting rows.
  - Needs a bit more a fiddle, colors + click areas
- Store grid sort direction (asc/desc) in url state
- Simplify node selection to one method. (over-ride existing card)
  - Remove clicking on name directly (links) to overlay new cards for now.
- Playing w/ grid-mode-toggle icons and labels
- Improves rendering in ff, change of shortcut keys for grid-mode-toggle
- Playing w/ clearer selection colors for grid-mode
- Slight change to selection-ui
- Fixes showNodeInTopology button visibility on the details-panel
  - Was using an old heuristic. Table-mode allows you to open child cards
    before the parent.
- Make it clear what the default sort is in tables
  - E.g. always show a sorting caret
- Sort grid-mode columns, first meta then metrics
- dancing-nodes rememdy #1: pause updates onRowHover
- Splits relatives out into their own columns
- Take into account scrollbar width for grid-mode col header position
- Tooltips on table column headers
- grid-mode: fixes first column headers (proc/container/c-by-image)
- Disable pause-on-hover, too aggresive
- reduce label column width a bit (33pc -> 25pc) for big tables
- Filter grid-mode onSearchChange
  - Rather than previous behaviour of waiting for an <enter>
- Show label_minor on pseudo nodes, that might not have much other info
- grid-mode: further reduce width of id column.
- Fixes go tests, properly moves parents into node-summary
- Fixes sorting of string columns w/ missing fields.
  - E.g. uptime. Where -1e-10 > '3days' doesn't work.
2016-08-03 08:50:37 +02:00
Simon Howe fa502ae6ad Removes the combined table-topo-view 2016-08-03 08:46:17 +02:00
Simon Howe c51e290127 Node grid view
More graphs!

Rank is not support by dagre any longer..

Quick go at using facebook's fixed-data-table

Kind of working, kind of interesting.

Hack on the details-panel table, supports sorting etc already!

No, this one! Hacks on the details panel's table.

Hovering on the table works! (highlights nodes)

wip get sorting going

Working on sorting, not behaving!

Pulling out methods to fns

Kind of demoable

More hacks to make it demoable
2016-08-03 08:37:17 +02:00
SimonandGitHub e7a0a96de2 Merge pull request #1485 from weaveworks/loading-indicator
Loading indicator
2016-08-03 08:22:22 +02:00
Simon Howe 19f08ee81f Review feedback on loading-indicator 2016-08-02 22:09:08 +02:00
David Kaltschmidt c4154bc770 Add browser console logging for websocket to render times
Print a log message when the time from websocket creation to first
render takes too long (100ms).
2016-08-02 17:14:31 +02:00
Alfonso Acosta 5d857d05d6 Remove and optimize more Copy()s 2016-08-02 13:29:35 +00:00
Alfonso Acosta bdd09d8aa9 Restore copying nodes when obtaining connection summaries 2016-08-02 13:29:34 +00:00
Matthias RadestockandAlfonso Acosta 1091225bf6 get rid of Node.Copy()
A shallow copy is sufficient. Which we get for free in most cases
since Node is passed around by value.
2016-08-02 12:42:39 +00:00
Alfonso AcostaandGitHub e42444c2e5 Merge pull request #1732 from weaveworks/metric-to-slice
Use slices instead of linked lists for Metric
2016-08-02 13:08:26 +01:00
Alfonso Acosta 4ed6afdb3a Review feedback 2016-08-01 20:06:05 +00:00
Alfonso Acosta eaa3baec9d Preallocate metrics when copying 2016-08-01 19:35:43 +00:00
Alfonso Acosta af08ba3245 Optimize Merge() for Metric 2016-08-01 19:34:32 +00:00
Alfonso Acosta 31f938cdad Remove Metric WithFirst() method
It was only used in tests and wasn't really necessary
2016-08-01 16:58:21 +00:00
Alfonso Acosta 8a950a59d6 Remove Metric Add() method
* Helps reduce garbage (MakeMetric() now takes a slice and there's a shorter version MakeSingletonMetric())
* Fixes bug computing Max (Min) in samples since using MakeMetric()
  was causing a default Max/Min of zero.
* Simplifies code a bit
2016-08-01 16:58:11 +00:00
DavidandGitHub 546e3ba972 Merge pull request #1734 from weaveworks/no-logo-on-cloud
Dont show weavescope logo when running in a frame
2016-08-01 16:55:17 +02:00
David Kaltschmidt 50fe1f8af2 Hide logo when in frame 2016-08-01 15:19:09 +02:00
David Kaltschmidt 1df544dbda Dont show weavescope logo when running in a frame
The logo wont show when running in a service
2016-08-01 15:09:20 +02:00
Alfonso Acosta 3e000662f4 Restore custom encoders/decoders for backwards compatibility 2016-08-01 11:07:03 +00:00
Alfonso Acosta b8bf60c6f1 Use slices instead of linked lists for Metric
Also:

* Remove Gob encoder/decoder
* Stop using custom encoders/decoders for Timestamps (both ugorji and the Golang JSON codecs use nanosecond precision).
* Use idiomatic way to check for existence in metric.LastSample()
2016-08-01 10:21:57 +00:00
Matthias Radestock 15cf1e16b2 micro optimisation: avoid some unnecessary copying 2016-07-29 18:56:06 +01:00
Matthias RadestockandGitHub 0525a2a95e Merge pull request #1728 from weaveworks/no-copy-merge
don't Copy() self on Merge()
2016-07-29 11:27:14 +01:00
Matthias Radestock 17fe25d8c3 shallow-copy instead of (deep) Copy() in Merge()
Merge() must not modify self or other; shallow-copying is sufficient
to achieve that.
2016-07-29 10:00:01 +01:00
Matthias Radestock c4fa72110c don't Copy() self on Merge()
Merge() is always returning a copy, so there is no need to Copy()
struct fields first before calling Merge() on them.

This reduces GC pressure (#1010) and helps overall app performance
(#1457).
2016-07-28 22:21:06 +01:00
Simon Howe 6e3bec8c70 Pulls loading out into new cmp, adds delayed show for loading 2016-07-28 17:59:48 +02:00
Simon Howe fba40de231 Typo and removing some more mutatey sounding verbs 2016-07-28 16:28:55 +02:00
Simon Howe 50a1c11eaa New and improved loading messages.
Are these getting better or worse...
2016-07-28 16:28:55 +02:00
Simon Howe 9a77b0d619 Less apologetic ui messages 2016-07-28 16:28:55 +02:00
Simon Howe 74e0540a00 More personal loading messages 2016-07-28 16:28:55 +02:00
Simon Howe b92a990b2e Restore log error message 2016-07-28 16:28:55 +02:00
Simon Howe 335cc1154a Smooth fade-out of node-loading message 2016-07-28 16:28:54 +02:00
Simon Howe 04f4071fd3 Handle loading message for empty topos correctly.
It was showing infinite loading...
2016-07-28 16:28:54 +02:00
Simon Howe 5df5e402f3 Avoid blurry text in topo loading message 2016-07-28 16:28:13 +02:00
Simon Howe 7dfae47c85 No title case on the loading messages 2016-07-28 16:28:12 +02:00
Simon Howe 7d14a787be Adds a loading indicator for the initial node-load
- Sometimes can take a second to get the initial nodes
- Not doing the transition between topos atm as its a bit distracting
  popping up and down.
2016-07-28 16:28:12 +02:00