5943 Commits
Author SHA1 Message Date
Paul Bellamy b5037f511c fix bug in containers being filtered by image name 2016-01-26 14:45:10 +00:00
Paul Bellamy 599bade33f Merge branch 'master' of github.com:weaveworks/scope 2016-01-26 10:03:55 +00:00
Tom Wilkie 0e3e3b74f8 Add benchmark for list topologies API. 2016-01-25 21:48:18 -08:00
Tom Wilkie b1a3a15ac0 A more debugging 2016-01-25 14:23:39 -08:00
Tom Wilkie f8cbaf0794 Flush cache between runs of the benchmark. 2016-01-25 13:53:38 -08:00
Tom Wilkie 41d48224aa Fix tests 2016-01-25 13:46:28 -08:00
Tom Wilkie b8daa02488 Memoise & cache the result of renderers, so we don't recalculate views multiple times. 2016-01-25 13:31:10 -08:00
Tom Wilkie fd8696ffa2 Merge pull request #838 from weaveworks/502-more-immutability
Use ps.Map for Counters and Sets, remove Metadata in favour of Latest.
2016-01-25 13:24:27 -08:00
Tom Wilkie 7a70a076b8 Make counter zero value useable. 2016-01-25 12:52:19 -08:00
Paul Bellamy b809f94272 make zero value of LatestMap valid 2016-01-25 17:33:24 +00:00
Tom Wilkie d1c0fcec2d Review feedback. 2016-01-25 08:39:42 -08:00
Paul Bellamy d44f9cbf77 fixing panic on EdgeMetadatas deserialization by making valid zero value 2016-01-25 15:51:14 +00:00
Paul Bellamy 5751db2a5a Always merge into the larger ps.Map
Because they are commutative and immutable, we can do this!
2016-01-25 15:25:01 +00:00
Tom Wilkie 586cfbfcea Rename 'by hostname' to 'by dns name' 2016-01-24 14:25:20 -08:00
Tom Wilkie 728572cb51 Lint 2016-01-24 14:06:44 -08:00
Tom Wilkie e125fb5e88 Add tests for counters 2016-01-24 14:04:08 -08:00
Tom Wilkie f2df789503 Add tests for latest map. 2016-01-24 13:55:48 -08:00
Tom Wilkie f071067289 Extend testing for EdgeMetadatas. 2016-01-24 09:50:08 -08:00
Tom Wilkie e5adb13888 Merge pull request #849 from weaveworks/847-cannot-exec-from-second-card
Fixes exec/attach from the 2nd+ card.
2016-01-24 09:23:15 -08:00
Tom Wilkie 2dc47e0c6c Fix up experimental. 2016-01-23 13:59:48 -08:00
Tom Wilkie bc3f946810 Make NodeMetadatas immutable. 2016-01-23 13:02:16 -08:00
Tom Wilkie 6b56475766 Use ps.Map for Counters and Sets, remove Metadata in favour of Latest.
Also
- Add more complicated report.json for benchmark
- Break up report/topology.go
- Implement our own DeepEqual for ps.Map
2016-01-22 15:10:32 -08:00
Alfonso Acosta 61cd64d5a5 Merge pull request #850 from weaveworks/improve-profiling-docs
Improve documentation about profiling
2016-01-22 15:37:03 +00:00
Alfonso AcostaandAlfonso Acosta 236c79c558 Improve documentation about profiling 2016-01-22 13:57:35 +00:00
Paul Bellamy 21ae0aa253 Merge commit '77949db' 2016-01-22 09:41:40 +00:00
Simon Howe 6edbd49791 Fixes pipe status when reloading page.
Correctly load in state from the url.
2016-01-21 21:15:54 +01:00
Tom Wilkie 3fd4edad8e Merge pull request #841 from weaveworks/840-no-metric-aggregation
Rename metric keys so they don't conflict and get merged between types
2016-01-21 09:46:19 -08:00
Simon Howe d5cf3d2c59 Fixes exec/attach from the 2nd+ card.
- Also fixes strange issue where hitting ESC while a terminal was
  active, would update the route, reload the top card, and break the
  terminal connection status.
2016-01-21 16:57:22 +01:00
Paul Bellamy e31520dddd refactor detailed key label rendering into a single dictionary 2016-01-21 11:55:45 +00:00
Paul Bellamy 77949db711 use constants for topology names (missed a few) 2016-01-20 16:16:58 +00:00
Paul Bellamy bf57aeb8d9 Rename the various metric keys so they don't accidentally overlap 2016-01-20 16:14:32 +00:00
Paul Bellamy 0190c15145 Making fixture report metrics more specific 2016-01-20 16:13:56 +00:00
Simon Howe bfa40f9f4b Removes sourcegraph badge from README
- Broken image at the moment which doesn't look great.
2016-01-20 09:06:49 +01:00
Tom Wilkie 2520eac507 Merge pull request #833 from weaveworks/832-i-broke-pprof
Loop in the http.DefaultServeMux for pprof.
2016-01-19 09:35:45 -08:00
Simon 6954c678a8 Merge pull request #839 from weaveworks/740-control-error-placement
Corrects the node control error placement
2016-01-19 18:26:46 +01:00
Simon Howe f63c50475c Corrects the node control error placement 2016-01-19 18:23:21 +01:00
Paul Bellamy 0afd151ea7 Merge pull request #752 from weaveworks/301-details-pain
Details panel redesign
2016-01-19 16:57:30 +00:00
Simon HoweandPaul Bellamy c43abd6075 Reconcile some details-panel stuff after the rebase. 2016-01-19 16:31:17 +00:00
Paul Bellamy 3d32d10e2d fixing up some performance issues in NodeSet 2016-01-19 16:31:08 +00:00
Simon Howe 0785d5393a Fixes pipes again
- Treat control objects that come back from the server as little
  black boxes.
- Pass our local client nodeId around more instead, use that for
  comparisons etc, (vs. inspecting the control object and doing brittle
  magic w/ the ids).
2016-01-19 16:48:35 +01:00
Paul BellamyandSimon Howe e7c9d4b771 adding a benchmark for the various render topologies 2016-01-19 16:47:49 +01:00
Paul BellamyandSimon Howe bf13a824d4 render detail status section for metadata or metrics 2016-01-19 16:47:49 +01:00
Paul BellamyandSimon Howe cb9d558665 Review feedback refactoring 2016-01-19 16:47:48 +01:00
Paul BellamyandSimon Howe 54d0db0441 templatize metric rendering and shorten column names 2016-01-19 16:47:48 +01:00
Paul BellamyandSimon Howe e30c9dc264 use constants for the topology names in Parents/metadata/metrics 2016-01-19 16:47:48 +01:00
Paul BellamyandSimon Howe 3cda328976 remove hostID from container image node ids 2016-01-19 16:47:48 +01:00
Tom WilkieandSimon Howe 9e61ad37f4 Get Pipes working again.
They stopped working because of the change to container node IDs (and rendered nodes IDs for containers).  The UI was comparing the IDs, which was never safe.  I have just removed that code.  This does leave the possibility of us having the pipe control operation take a long time, the user navigate to a different node, and then the terminal pop up, but I think thats better that teaching the UI to understand the format of the node IDs.
2016-01-19 16:47:48 +01:00
David KaltschmidtandSimon Howe d39fd847b7 Details Panel UI Redesign
Refactored nodedetails to support multiple data sets, probably broke some tests
  Allow api requests to out-of-view topologies
  Fix ESC behavior with details panel
  Stack details panel like cards
  Details pain side-by-side
  Details panel piles
  Fix node details table header styles
  Render load and not-found captions like relatives
  Fix topology click action
  Make node detail tables sortable
  Grouped metrics for details health
  Group metrics in same style
  Link node details children
  Fix scroll issues on double-details
  Fix DESC sort order for node details table
  Save selected node labels in state - allows rendering of node labels from other topologies before details are loaded
  Change detail card UX, newest one at top, pile at bottom
  Details panel one pile w/ animation
  Sort details table nodes by metadata too
  Animate sidepanel from children too
  Fix radial layout
  Dont set origin if a node was already selected, suppresses animation
  stack effect: shift top cards to the left, shrink lower cards vertically
  Clear details card stack if sibling is selected
  Check if node is still selected on API response
  Make detail table sorters robust against non-uniform metadata
  Dont show scrollbar all the time, fix sort icon issue
  Button to show topology for relative
  Overflow metrics for details panel health
  Fix JS error when no metrics are available for container image details
  Column-based rendering of node details table
  Fix JS tests
  Review feedback (UI)
2016-01-19 16:47:05 +01:00
Paul BellamyandSimon Howe 56122dd0cc Details panel backend redesign
Megasquish:
  [app] remove unused edge endpoint
  [WIP] refactoring node details api endpoint
  [WIP] plumbing the children through the rendering process
  adding IDList.Remove and StringSet.Remove
  [WIP] working on adding parents to detailed node renderings
  WIP UI components with mock backend data for new details
  grouping children by type
  UI components for node details health and info
  metric formatters for details panel
  Column headers and links for details table
  [WIP] started on rendering node metadata and metrics in the detail view
  DetailedNode.LabelMajor -> DetailedNode.Label
  rendering decent labels for parents of detailed nodes
  render metrics onto the top-level detailed node
  removing dead code
  Links to relatives
  metrics have a Format not Unit
  Show more/less actions for tables and relatives
  adjusted metric formatter
  TopologyTagger should tag k8s topology nodes
  make renderablenode ids more consistent, e.g. container:abcd1234
  working on rendering correct summaries for each node
  adding report.Node.Rank, so that merging is independent of order
  rendering children and parents correctly
  output child renderableNode ids, so we can link to them
  add group field to metrics, so they can be grouped
  Refactored details health items to prepare for grouping
  add metrics to processNodeSummaries
  hide summary section if there is no data for it
  fixing up tests
  moving detailed node rendering into a separate package
  Node ID/Topology are fields not metadata
    - This way I think we don't have to care about Metadata being non-commutative.
    - ID and topology are still non-commutative, as I'm not sure how to sanely
  merge them, but it's possible we don't care.
  host memory usage is a filesize, not a percent
  working on fixing some tests
  adding children to hosts detail panel
    - Had to redo how parents are calculated, so that children wouldn't interfere with it
    - have to have the host at the end because it is non-commutative
  only render links for linkable children (i.e. not unconnected processes)
  resolving TODOs
  fixing up lint errors
  make nil a valid value for render.Children so tests are cleaner
  working on backend tests
  make client handle missing metrics property
  Stop rendering container image nodes with process summaries/parents
  fix parent link to container images
  Calculate parents as a set on report.Node (except k8s)
  refactoring detailed.NodeSummary stuff
  removing RenderableNode.Summary*, we already track it on report.Node
  working on tests
  add Columns field to NodeSummaryGroup
  fixing up render/topologies_test
  fix children links to container images
  get children of hosts rendering right
  working on host renderer tests
  Change container report.Node.ID to a1b2c3;<container>
  The id should be globally unique, so we don't need the host id.
    This lets the kubernetes probe return a container node with the pod id,
    which will get merged into the real containers with other reports. The
    catch is that the kubernetes api doesn't tell us which hostname the
    container is running on, so we can't populate the old-style node ids.
  change terminology of system pods and services
  Fix kubernetes services with no selector
  Fixes handling of kubernetes service, which has no pods
  fix parent links for pods/services
  refactor detailed metadata to include sets and latest data
  fixing up host rendering tests
  fleshing out tests for node metadata and metrics
  don't render container pseudo-nodes as processes
  Update test for id format change.
2016-01-19 16:39:37 +01:00
Simon 359ec29c09 Merge pull request #797 from weaveworks/758-independent-node-controls
Fix node controls so they behave independently across nodes
2016-01-19 14:41:37 +01:00