github/weave-scope
1
0
Fork 0
mirror of https://github.com/weaveworks/scope.git synced 2026-07-24 07:46:41 +00:00
Code Issues Packages Projects Releases Wiki Activity

Refactor if/else into a switch statement

Browse Source 
Also, extracts strings into constants
This commit is contained in:
gotjosh
2018-10-15 21:30:45 +01:00
parent 3faf109b8f
commit fbb027752f
1 changed files with 12 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

19
probe/cri/registry.go
View File

@@ -11,7 +11,10 @@ import (
client "github.com/weaveworks/scope/cri/runtime"
)
const unixProtocol = "unix"
const (
unixProtocol = "unix"
tcpProtocol = "tcp"
)
func dial(addr string, timeout time.Duration) (net.Conn, error) {
return net.DialTimeout(unixProtocol, addr, timeout)
@@ -48,17 +51,19 @@ func parseEndpointWithFallbackProtocol(endpoint string, fallbackProtocol string)
func parseEndpoint(endpoint string) (string, string, error) {
u, err := url.Parse(endpoint)
if err != nil {
return "", "", err
}
if u.Scheme == "tcp" {
return "tcp", u.Host, fmt.Errorf("endpoint was not unix socket %v", u.Scheme)
} else if u.Scheme == "unix" {
return "unix", u.Path, nil
} else if u.Scheme == "" {
switch u.Scheme {
case tcpProtocol:
return tcpProtocol, u.Host, fmt.Errorf("endpoint was not unix socket %v", u.Scheme)
case unixProtocol:
return unixProtocol, u.Path, nil
case "":
return "", "", nil
} else {
default:
return u.Scheme, "", fmt.Errorf("protocol %q not supported", u.Scheme)
}
}