github/weave-scope
1
0
Fork 0
mirror of https://github.com/weaveworks/scope.git synced 2026-07-15 19:41:02 +00:00
Code Issues Packages Projects Releases Wiki Activity

Add static map of common keys to reduce allocations

Browse Source
This commit is contained in:
Matthias Radestock
2017-12-11 19:25:36 +00:00
parent 1f2247a8c4
commit e24d3e93fe
4 changed files with 114 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
extras/generate_latest_map
View File

@@ -243,7 +243,7 @@ function generate_latest_map() {
z.DecSendContainerState(containerMapKey)
var key string
if !r.TryDecodeAsNil() {
key = r.DecodeString()
key = lookupCommonKey(r.DecodeStringAsBytes())
}
i := m.locate(key)
(*m)[i].key = key

4
report/latest_map_generated.go
View File

@@ -211,7 +211,7 @@ func (m *StringLatestMap) CodecDecodeSelf(decoder *codec.Decoder) {
z.DecSendContainerState(containerMapKey)
var key string
if !r.TryDecodeAsNil() {
key = r.DecodeString()
key = lookupCommonKey(r.DecodeStringAsBytes())
}
i := m.locate(key)
(*m)[i].key = key
@@ -432,7 +432,7 @@ func (m *NodeControlDataLatestMap) CodecDecodeSelf(decoder *codec.Decoder) {
z.DecSendContainerState(containerMapKey)
var key string
if !r.TryDecodeAsNil() {
key = r.DecodeString()
key = lookupCommonKey(r.DecodeStringAsBytes())
}
i := m.locate(key)
(*m)[i].key = key

2
report/map_helpers.go
View File

@@ -110,7 +110,7 @@ func mapRead(decoder *codec.Decoder, decodeValue func(isNil bool) interface{}) p
var key string
z.DecSendContainerState(containerMapKey)
if !r.TryDecodeAsNil() {
key = r.DecodeString()
key = lookupCommonKey(r.DecodeStringAsBytes())
}
z.DecSendContainerState(containerMapValue)

110
report/map_keys.go
View File

@@ -78,3 +78,113 @@ const (
ECSScaleUp = "ecs_scale_up"
ECSScaleDown = "ecs_scale_down"
)
/* Lookup table to allow msgpack/json decoder to avoid heap allocation
for common ps.Map keys. The map is static so we don't have to lock
access from multiple threads and don't have to worry about it
getting clogged with values that are only used once.
*/
var commonKeys = map[string]string{
Endpoint: Endpoint,
Process: Process,
Container: Container,
Pod: Pod,
Service: Service,
Deployment: Deployment,
ReplicaSet: ReplicaSet,
DaemonSet: DaemonSet,
StatefulSet: StatefulSet,
CronJob: CronJob,
ContainerImage: ContainerImage,
Host: Host,
Overlay: Overlay,
ECSService: ECSService,
ECSTask: ECSTask,
SwarmService: SwarmService,
HostNodeID: HostNodeID,
ControlProbeID: ControlProbeID,
DoesNotMakeConnections: DoesNotMakeConnections,
ReverseDNSNames: ReverseDNSNames,
SnoopedDNSNames: SnoopedDNSNames,
CopyOf: CopyOf,
PID: PID,
Name: Name,
PPID: PPID,
Cmdline: Cmdline,
Threads: Threads,
DockerContainerID: DockerContainerID,
DockerImageID: DockerImageID,
DockerImageName: DockerImageName,
DockerImageSize: DockerImageSize,
DockerImageVirtualSize: DockerImageVirtualSize,
DockerIsInHostNetwork: DockerIsInHostNetwork,
DockerServiceName: DockerServiceName,
DockerStackNamespace: DockerStackNamespace,
DockerStopContainer: DockerStopContainer,
DockerStartContainer: DockerStartContainer,
DockerRestartContainer: DockerRestartContainer,
DockerPauseContainer: DockerPauseContainer,
DockerUnpauseContainer: DockerUnpauseContainer,
DockerRemoveContainer: DockerRemoveContainer,
DockerAttachContainer: DockerAttachContainer,
DockerExecContainer: DockerExecContainer,
DockerContainerName: DockerContainerName,
DockerContainerCommand: DockerContainerCommand,
DockerContainerPorts: DockerContainerPorts,
DockerContainerCreated: DockerContainerCreated,
DockerContainerNetworks: DockerContainerNetworks,
DockerContainerIPs: DockerContainerIPs,
DockerContainerHostname: DockerContainerHostname,
DockerContainerIPsWithScopes: DockerContainerIPsWithScopes,
DockerContainerState: DockerContainerState,
DockerContainerStateHuman: DockerContainerStateHuman,
DockerContainerUptime: DockerContainerUptime,
DockerContainerRestartCount: DockerContainerRestartCount,
DockerContainerNetworkMode: DockerContainerNetworkMode,
KubernetesName: KubernetesName,
KubernetesNamespace: KubernetesNamespace,
KubernetesCreated: KubernetesCreated,
KubernetesIP: KubernetesIP,
KubernetesObservedGeneration: KubernetesObservedGeneration,
KubernetesReplicas: KubernetesReplicas,
KubernetesDesiredReplicas: KubernetesDesiredReplicas,
KubernetesNodeType: KubernetesNodeType,
KubernetesGetLogs: KubernetesGetLogs,
KubernetesDeletePod: KubernetesDeletePod,
KubernetesScaleUp: KubernetesScaleUp,
KubernetesScaleDown: KubernetesScaleDown,
KubernetesUpdatedReplicas: KubernetesUpdatedReplicas,
KubernetesAvailableReplicas: KubernetesAvailableReplicas,
KubernetesUnavailableReplicas: KubernetesUnavailableReplicas,
KubernetesStrategy: KubernetesStrategy,
KubernetesFullyLabeledReplicas: KubernetesFullyLabeledReplicas,
KubernetesState: KubernetesState,
KubernetesIsInHostNetwork: KubernetesIsInHostNetwork,
KubernetesRestartCount: KubernetesRestartCount,
KubernetesMisscheduledReplicas: KubernetesMisscheduledReplicas,
KubernetesPublicIP: KubernetesPublicIP,
KubernetesSchedule: KubernetesSchedule,
KubernetesSuspended: KubernetesSuspended,
KubernetesLastScheduled: KubernetesLastScheduled,
KubernetesActiveJobs: KubernetesActiveJobs,
ECSCluster: ECSCluster,
ECSCreatedAt: ECSCreatedAt,
ECSTaskFamily: ECSTaskFamily,
ECSServiceDesiredCount: ECSServiceDesiredCount,
ECSServiceRunningCount: ECSServiceRunningCount,
ECSScaleUp: ECSScaleUp,
ECSScaleDown: ECSScaleDown,
}
func lookupCommonKey(b []byte) string {
if key, ok := commonKeys[string(b)]; ok {
return key
}
return string(b)
}