Rename Applications -> Process, sort topologies by rank.

This commit is contained in:
Tom Wilkie
2016-01-27 19:40:31 -08:00
parent 00755896de
commit d3b11ee040
3 changed files with 15 additions and 10 deletions

View File

@@ -22,6 +22,7 @@ var (
id: "pods",
renderer: render.PodRenderer,
Name: "Pods",
Rank: 3,
Options: map[string][]APITopologyOption{"system": {
{"show", "System pods shown", false, render.FilterNoop},
{"hide", "System pods hidden", true, render.FilterSystem},
@@ -56,9 +57,10 @@ func init() {
// be the verb to get to that state
topologyRegistry.add(
APITopologyDesc{
id: "applications",
id: "processes",
renderer: render.FilterUnconnected(render.ProcessWithContainerNameRenderer),
Name: "Applications",
Name: "Processes",
Rank: 1,
Options: map[string][]APITopologyOption{"unconnected": {
// Show the user why there are filtered nodes in this view.
// Don't give them the option to show those nodes.
@@ -66,8 +68,8 @@ func init() {
}},
},
APITopologyDesc{
id: "applications-by-name",
parent: "applications",
id: "processes-by-name",
parent: "processes",
renderer: render.FilterUnconnected(render.ProcessNameRenderer),
Name: "by name",
Options: map[string][]APITopologyOption{"unconnected": {
@@ -79,6 +81,7 @@ func init() {
id: "containers",
renderer: render.ContainerWithImageNameRenderer,
Name: "Containers",
Rank: 2,
Options: containerFilters,
},
APITopologyDesc{
@@ -99,6 +102,7 @@ func init() {
id: "hosts",
renderer: render.HostRenderer,
Name: "Hosts",
Rank: 4,
Options: map[string][]APITopologyOption{},
},
)
@@ -117,6 +121,7 @@ type APITopologyDesc struct {
renderer render.Renderer
Name string `json:"name"`
Rank int `json:"rank"`
Options map[string][]APITopologyOption `json:"options"`
URL string `json:"url"`

View File

@@ -71,12 +71,12 @@ func TestAPITopologyContainers(t *testing.T) {
}
}
func TestAPITopologyApplications(t *testing.T) {
func TestAPITopologyProcesses(t *testing.T) {
ts := topologyServer()
defer ts.Close()
is404(t, ts, "/api/topology/applications/foobar")
is404(t, ts, "/api/topology/processes/foobar")
{
body := getRawJSON(t, ts, "/api/topology/applications/"+expected.ServerProcessID)
body := getRawJSON(t, ts, "/api/topology/processes/"+expected.ServerProcessID)
var node app.APINode
if err := json.Unmarshal(body, &node); err != nil {
t.Fatal(err)
@@ -88,7 +88,7 @@ func TestAPITopologyApplications(t *testing.T) {
}
{
body := getRawJSON(t, ts, "/api/topology/applications-by-name/"+
body := getRawJSON(t, ts, "/api/topology/processes-by-name/"+
url.QueryEscape(fixture.Client1Name))
var node app.APINode
if err := json.Unmarshal(body, &node); err != nil {
@@ -133,7 +133,7 @@ func TestAPITopologyHosts(t *testing.T) {
func TestAPITopologyWebsocket(t *testing.T) {
ts := topologyServer()
defer ts.Close()
url := "/api/topology/applications/ws"
url := "/api/topology/processes/ws"
// Not a websocket request
res, _ := checkGet(t, ts, url)

View File

@@ -58,7 +58,7 @@ export default class Topologies extends React.Component {
render() {
const topologies = _.sortBy(this.props.topologies, function(topology) {
return topology.name;
return topology.rank;
});
return (