github/weave-scope
1
0
Fork 0
mirror of https://github.com/weaveworks/scope.git synced 2026-07-28 09:41:57 +00:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #2437 from kinvolk/alban/gzip-compression-level-default

Browse Source 
gzip: change compression level to the default
This commit is contained in:
Bryan Boreham
2017-04-18 10:45:38 +01:00
committed by GitHub
parent b58832df7e a8af81fe20
commit c944225475
3 changed files with 4 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
app/router.go
View File

@@ -150,7 +150,7 @@ func RegisterReportPostHandler(a Adder, router *mux.Router) {
// a.Add(..., buf) assumes buf is gzip'd msgpack
if !isMsgpack {
buf = bytes.Buffer{}
rpt.WriteBinary(&buf, gzip.BestCompression)
rpt.WriteBinary(&buf, gzip.DefaultCompression)
}
if err := a.Add(ctx, rpt, buf.Bytes()); err != nil {

2
probe/appclient/report_publisher.go
View File

@@ -29,6 +29,6 @@ func (p *ReportPublisher) Publish(r report.Report) error {
})
}
buf := &bytes.Buffer{}
r.WriteBinary(buf, gzip.BestCompression)
r.WriteBinary(buf, gzip.DefaultCompression)
return p.publisher.Publish(buf)
}

4
report/marshal_test.go
View File

@@ -12,7 +12,7 @@ import (
func TestRoundtrip(t *testing.T) {
var buf bytes.Buffer
r1 := report.MakeReport()
r1.WriteBinary(&buf, gzip.BestCompression)
r1.WriteBinary(&buf, gzip.DefaultCompression)
bytes := append([]byte{}, buf.Bytes()...) // copy the contents for later
r2, err := report.MakeFromBinary(&buf)
if err != nil {
@@ -49,7 +49,7 @@ func TestMoreCompressionMeansSmaller(t *testing.T) {
// Make sure that 0 level compression actually does compress less.
var buf1, buf2 bytes.Buffer
r := report.MakeReport()
r.WriteBinary(&buf1, gzip.BestCompression)
r.WriteBinary(&buf1, gzip.DefaultCompression)
r.WriteBinary(&buf2, 0)
if buf1.Len() >= buf2.Len() {
t.Errorf("Compression doesn't change size: %v >= %v", buf1.Len(), buf2.Len())