github/weave-scope
1
0
Fork 0
mirror of https://github.com/weaveworks/scope.git synced 2026-07-28 01:31:17 +00:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #2668 from weaveworks/2665-connection-pid-attribution

Browse Source 
ignore endpoints with >1 adjacency in process rendering

This eliminates the worst effects of #2665.
This commit is contained in:
Matthias Radestock
2017-06-30 13:10:10 +01:00
committed by GitHub
parent e65c80d71a 708931f98a
commit c5b2c9dc3d
1 changed files with 7 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
render/process.go
View File

@@ -123,6 +123,13 @@ func MapEndpoint2Process(n report.Node, local report.Networks) report.Nodes {
return report.Nodes{}
}
if len(n.Adjacency) > 1 {
// We cannot be sure that the pid is associated with all the
// connections. It is better to drop such an endpoint than
// risk rendering bogus connections.
return report.Nodes{}
}
id := report.MakeProcessNodeID(report.ExtractHostID(n), pid)
node := NewDerivedNode(id, n).WithTopology(report.Process)
node.Latest = node.Latest.Set(process.PID, timestamp, pid)