github/weave-scope
1
0
Fork 0
mirror of https://github.com/weaveworks/scope.git synced 2026-07-23 07:16:47 +00:00
Code Issues Packages Projects Releases Wiki Activity

Tag images at build time

Browse Source 
`push_images` used to tag and publish the latest built image, no matter what version or what branch or tag was checked out.
Since `bin/release build` and `bin/release publish` can be run at different times, it was possible for the latest built image to change. At which point `bin/release publish` would tag and publish an intended image.

Moving image tagging at build time will prevent this from happening again.
This commit is contained in:
Roberto Bruggemann
2017-12-14 15:39:19 +00:00
parent 46551998cc
commit be5f216342
1 changed files with 14 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

19
bin/release
View File

@@ -104,6 +104,8 @@ build() {
# exit 1
#fi
tag_images
echo -e '\u2713 Build OK'
echo '** Release artefacts in' "$RELEASE_DIR"
}
@@ -232,17 +234,24 @@ publish() {
fi
}
push_images() {
echo "== Tagging and pushing images on docker hub and quay.io as user $DOCKERHUB_USER"
tag_images() {
echo "== Tagging images for docker hub and quay.io as user $DOCKERHUB_USER"
for IMAGE in "scope" "cloud-agent"; do
$SUDO docker tag "$DOCKERHUB_USER/$IMAGE" "$DOCKERHUB_USER/$IMAGE:$VERSION"
$SUDO docker push "$DOCKERHUB_USER/$IMAGE:$VERSION"
$SUDO docker tag "$DOCKERHUB_USER/$IMAGE:$VERSION" "$DOCKERHUB_USER/$IMAGE:latest_release"
$SUDO docker push "$DOCKERHUB_USER/$IMAGE:latest_release"
$SUDO docker tag "$DOCKERHUB_USER/$IMAGE:$VERSION" "quay.io/$DOCKERHUB_USER/$IMAGE:$VERSION"
done
echo "** Docker images tagged"
}
push_images() {
echo "== Pushing images on docker hub and quay.io as user $DOCKERHUB_USER"
for IMAGE in "scope" "cloud-agent"; do
$SUDO docker push "$DOCKERHUB_USER/$IMAGE:$VERSION"
$SUDO docker push "$DOCKERHUB_USER/$IMAGE:latest_release"
$SUDO docker push "quay.io/$DOCKERHUB_USER/$IMAGE:$VERSION"
done
echo "** Docker images tagged and pushed"
echo "** Docker images pushed"
}
usage() {