github/weave-scope
1
0
Fork 0
mirror of https://github.com/weaveworks/scope.git synced 2026-07-16 03:49:52 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: report http error if /api call fails

Browse Source 
Previously it would try to run the JSON decoder on a string like "404
not found" and report that failing.
This commit is contained in:
Bryan Boreham
2019-10-06 17:27:46 +00:00
parent bd9f88b985
commit b24917993e
1 changed files with 3 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
probe/appclient/app_client.go
View File

@@ -192,6 +192,9 @@ func (c *appClient) Details() (xfer.Details, error) {
if err != nil {
return result, err
}
if resp.StatusCode != http.StatusOK {
return result, fmt.Errorf("Error response from %s: %s", c.url("/api"), resp.Status)
}
defer resp.Body.Close()
if err := codec.NewDecoder(resp.Body, &codec.JsonHandle{}).Decode(&result); err != nil {
return result, err