github/weave-scope
1
0
Fork 0
mirror of https://github.com/weaveworks/scope.git synced 2026-07-28 01:31:17 +00:00
Code Issues Packages Projects Releases Wiki Activity

refactor(logs): Add reporter name to error logs.

Browse Source 
1. Adding reporter name to logs improves tracing of error.
2. Capitalize first letter of error log.

Fixes https://github.com/weaveworks/scope/issues/3306

Signed-off-by: Prince Rachit Sinha <prince.rachit@mayadata.io>
This commit is contained in:
Prince Rachit Sinha
2018-09-30 11:03:11 +05:30
parent c0b60a1653
commit a097b7a590
1 changed files with 4 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
probe/probe.go
View File

@@ -148,7 +148,7 @@ func (p *Probe) tick() {
err := ticker.Tick()
metrics.MeasureSince([]string{ticker.Name(), "ticker"}, t)
if err != nil {
log.Errorf("error doing ticker: %v", err)
log.Errorf("Error doing ticker: %v", err)
}
}
}
@@ -165,7 +165,7 @@ func (p *Probe) report() report.Report {
}
metrics.MeasureSince([]string{rep.Name(), "reporter"}, t)
if err != nil {
log.Errorf("error generating report: %v", err)
log.Errorf("Error generating %s report: %v", rep.Name(), err)
newReport = report.MakeReport() // empty is OK to merge
}
reports <- newReport
@@ -190,7 +190,7 @@ func (p *Probe) tag(r report.Report) report.Report {
}
metrics.MeasureSince([]string{tagger.Name(), "tagger"}, t)
if err != nil {
log.Errorf("error applying tagger: %v", err)
log.Errorf("Error applying tagger: %v", err)
}
}
return r
@@ -213,7 +213,7 @@ ForLoop:
})
}
if err := p.publisher.Publish(rpt); err != nil {
log.Infof("publish: %v", err)
log.Infof("Publish: %v", err)
}
}