github/weave-scope
1
0
Fork 0
mirror of https://github.com/weaveworks/scope.git synced 2026-07-16 03:49:52 +00:00
Code Issues Packages Projects Releases Wiki Activity

Remove impossible case of an empty plugin ID

Browse Source 
Plugin ID must be non-empty when the plugin is created and the
followup reports cannot change it.
This commit is contained in:
Krzesimir Nowak
2016-07-15 18:00:50 +02:00
parent 9d48fdc32c
commit 993eebeea9
1 changed files with 0 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
probe/plugins/registry.go
View File

@@ -283,8 +283,6 @@ func (p *Plugin) Report() (result report.Report, err error) {
switch {
case spec.APIVersion != p.expectedAPIVersion:
err = fmt.Errorf("incorrect API version: expected %q, got %q", p.expectedAPIVersion, spec.APIVersion)
case spec.ID == "":
err = fmt.Errorf("spec must contain an id")
case spec.Label == "":
err = fmt.Errorf("spec must contain a label")
case !foundReporter: