github/weave-scope
1
0
Fork 0
mirror of https://github.com/weaveworks/scope.git synced 2026-07-28 09:41:57 +00:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #3627 from weaveworks/buffered-docker-events

Browse Source 
fix(probe): Use a buffered chan to reduce the chance of losing events
This commit is contained in:
Bryan Boreham
2019-06-05 17:05:16 +01:00
committed by GitHub
parent 7cf5712c89 380dd8357f
commit 954e86e7ff
1 changed files with 3 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
probe/docker/registry.go
View File

@@ -176,7 +176,9 @@ func (r *registry) listenForEvents() bool {
// Next, start listening for events. We do this before fetching
// the list of containers so we don't miss containers created
// after listing but before listening for events.
events := make(chan *docker_client.APIEvents)
// Use a buffered chan so the client library can run ahead of the listener
// - Docker will drop an event if it is not collected quickly enough.
events := make(chan *docker_client.APIEvents, 1024)
if err := r.client.AddEventListener(events); err != nil {
log.Errorf("docker registry: %s", err)
return true